[GitHub] [pinot] klsince commented on a diff in pull request #9440: Refine IndexHandler methods a bit to make them reentrant

[GitBox <gi...@apache.org>]

klsince commented on code in PR #9440:
URL: https://github.com/apache/pinot/pull/9440#discussion_r975762288


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/FSTIndexHandler.java:
##########
@@ -74,22 +74,23 @@ public class FSTIndexHandler implements IndexHandler {
   public FSTIndexHandler(SegmentMetadata segmentMetadata, IndexLoadingConfig indexLoadingConfig) {
     _segmentMetadata = segmentMetadata;
     _fstType = indexLoadingConfig.getFSTIndexType();
-    _columnsToAddIdx = new HashSet<>(indexLoadingConfig.getFSTIndexColumns());
+    _columnsToAddIdx = indexLoadingConfig.getFSTIndexColumns();

Review Comment:
   I see BF/H3 hander doesn't hold indexLoadingConfig reference either, but configs for creating BF/H3. 
   The handlers in this PR don't have specific configs from indexLoadingConfig either, so not hold its reference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org