You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/30 00:07:35 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4446: Add
support in the rebalancer for the user to provide minimum number of serving
replicas
codecov-io edited a comment on issue #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas
URL: https://github.com/apache/incubator-pinot/pull/4446#issuecomment-514408423
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=h1) Report
> Merging [#4446](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8717e3508202a6d4f6fa457f6f6e2384479e5b9b?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `62.74%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4446 +/- ##
============================================
+ Coverage 65.53% 65.64% +0.11%
Complexity 20 20
============================================
Files 1065 1065
Lines 55247 55413 +166
Branches 8025 8051 +26
============================================
+ Hits 36208 36378 +170
+ Misses 16433 16402 -31
- Partials 2606 2633 +27
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...x/core/rebalance/RebalanceUserConfigConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYmFsYW5jZS9SZWJhbGFuY2VVc2VyQ29uZmlnQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `63.16% <0%> (-0.18%)` | `0 <0> (ø)` | |
| [...inot/common/restlet/resources/RebalanceResult.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvUmViYWxhbmNlUmVzdWx0LmphdmE=) | `76.19% <100%> (+7.44%)` | `0 <0> (ø)` | :arrow_down: |
| [...oller/api/resources/PinotTableRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFibGVSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `50.94% <100%> (+0.94%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/controller/helix/core/TableRebalancer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1RhYmxlUmViYWxhbmNlci5qYXZh) | `63.6% <61.78%> (-3.64%)` | `0 <0> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvT3JCbG9ja0RvY0lkU2V0LmphdmE=) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `86.95% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...nsport/netty/PooledNettyClientResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvbmV0dHkvUG9vbGVkTmV0dHlDbGllbnRSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `85.41% <0%> (-4.17%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `89.28% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-pinot/pull/4446/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=footer). Last update [8717e35...52c49bc](https://codecov.io/gh/apache/incubator-pinot/pull/4446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org