You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/04 16:25:57 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #14588: Fill DagBag from dag_folder setting for upgrade rules

XD-DENG commented on a change in pull request #14588:
URL: https://github.com/apache/airflow/pull/14588#discussion_r587616725



##########
File path: airflow/upgrade/rules/custom_operator_metaclass_rule.py
##########
@@ -17,6 +17,7 @@
 
 from __future__ import absolute_import
 
+from airflow import conf

Review comment:
       Hi @kenfinster, I understand there is such usage (the example you have nicely given). But I think it's better to adopt @ephraimbuddy 's suggestion even if both styles work.
   
   One of the reasons can be to promote the "Airflow 2.0 style". `from airflow import conf` doesn't work in 2.0.x.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org