You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/04 10:03:31 UTC

[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on pull request #185: [YUNIKORN-386] Passed spark appID in annotation

kingamarton commented on pull request #185:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/185#issuecomment-687052437


   > hi @kingamarton could u pls fix the remaining issue in this PR?
   
   Sure, I deleted the failing TestGetApplicationIDFromPod from the application_test, because there is a test case for that method in utils_test.go. That test case belongs to the utils_test and not to application_test, so I kept this last one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org