You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "KacerCZ (via GitHub)" <gi...@apache.org> on 2023/01/28 17:45:40 UTC

[GitHub] [netbeans] KacerCZ opened a new issue, #5380: PHP: Extra space after ternary operator in method call

KacerCZ opened a new issue, #5380:
URL: https://github.com/apache/netbeans/issues/5380

   ### Apache NetBeans version
   
   Apache NetBeans 16
   
   ### What happened
   
   Formatting ternary or null-coalescing operator inside method call adds extra space after expression and before closing parenthesis.
   
   ### How to reproduce
   
   Create file with following contents:
   ```php
   <?php
   
   var_dump($a);
   var_dump($a ? 1 : 2);
   var_dump($a ?? null);
   ```
   - Check option in formatting for PHP language Spaces > Within Parenthesis > Method / Function Call
   - Reformat code twice
   - There are two spaces before closing parenthesis instead of only one.
   
   Actual result:
   ```php
   <?php
   
   var_dump( $a );
   var_dump( $a ? 1 : 2  ); // <- Extra space before )
   var_dump( $a ?? null  ); // <- Extra space before )
   ```
   
   ### Did this work correctly in an earlier version?
   
   No / Don't know
   
   ### Operating System
   
   Ubuntu 22.10
   
   ### JDK
   
   OpenJDK 17.0.5
   
   ### Apache NetBeans packaging
   
   Apache NetBeans provided installer
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request?
   
   Yes
   
   ### Code of Conduct
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [I] PHP: Extra space after ternary operator in method call [netbeans]

Posted by "KacerCZ (via GitHub)" <gi...@apache.org>.
KacerCZ commented on issue #5380:
URL: https://github.com/apache/netbeans/issues/5380#issuecomment-1817525599

   @junichi11 I was investigating the issue but don't know how to fix it, so I didn't assign it to myself.
   
   Only thing I found out, that there are probably some extra formatting tokens after ternary and null-coalescing operators, which cause the issue by adding extra space.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [I] PHP: Extra space after ternary operator in method call [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on issue #5380:
URL: https://github.com/apache/netbeans/issues/5380#issuecomment-1817279925

   > Are you willing to submit a pull request?
   Yes
   
   So, nobody assign to it.
   
   @KacerCZ I'll take over it if you don't fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [I] PHP: Extra space after ternary operator in method call [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on issue #5380:
URL: https://github.com/apache/netbeans/issues/5380#issuecomment-1817702569

   OK, I'll assign this to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [I] PHP: Extra space after ternary operator in method call [netbeans]

Posted by "terax6669 (via GitHub)" <gi...@apache.org>.
terax6669 commented on issue #5380:
URL: https://github.com/apache/netbeans/issues/5380#issuecomment-1816666261

   @junichi11 This has been untouched for almost a year, nobody is assigned to the issue.
   I checked and this bug still exists in current versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [I] PHP: Extra space after ternary operator in method call [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 closed issue #5380: PHP: Extra space after ternary operator in method call
URL: https://github.com/apache/netbeans/issues/5380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists