You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/30 09:17:06 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #2414: bindy: do not embed useless resources #2413
aldettinger opened a new pull request #2414:
URL: https://github.com/apache/camel-quarkus/pull/2414
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #2414: bindy: do not embed useless resources #2413
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #2414:
URL: https://github.com/apache/camel-quarkus/pull/2414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #2414: bindy: do not embed useless resources #2413
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #2414:
URL: https://github.com/apache/camel-quarkus/pull/2414#issuecomment-810292427
The build issue seems unrelated, so merging. Thanks for review :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2414: bindy: do not embed useless resources #2413
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2414:
URL: https://github.com/apache/camel-quarkus/pull/2414#discussion_r603932323
##########
File path: docs/modules/ROOT/pages/reference/extensions/core.adoc
##########
@@ -168,7 +168,7 @@ What to do if it is not possible to extract CSimple expressions from a route def
|icon:lock[title=Fixed at build time] [[quarkus.camel.main.enabled]]`link:#quarkus.camel.main.enabled[quarkus.camel.main.enabled]`
-If `true` all `camel-main` features are enabled; otherwise no `camel-main` features are enabled. See described the xref:user-guide/bootstrap.adoc[Bootstrap] camel-main section of the documentation for more details.
+If `true` all `camel-main` features are enabled; otherwise no `camel-main` features are enabled. See described the link:https://camel.apache.org/camel-quarkus/latest/user-guide/bootstrap.html#_camel_main[Bootstrap] section of Camel Quarkus documentation for more details.
Review comment:
This change probably wasn't intended. A fix was made directly to the generated doc file:
https://github.com/apache/camel-quarkus/commit/c03d38234694fe04eb91bc04de4332fc93bcea8d#diff-46b42b4229cd7a39c564e780bb665a8bde4fdf722007e8473f167fe53ed4b995
So it'll need applying to the doc sources too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2414: bindy: do not embed useless resources #2413
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2414:
URL: https://github.com/apache/camel-quarkus/pull/2414#discussion_r603940503
##########
File path: docs/modules/ROOT/pages/reference/extensions/core.adoc
##########
@@ -168,7 +168,7 @@ What to do if it is not possible to extract CSimple expressions from a route def
|icon:lock[title=Fixed at build time] [[quarkus.camel.main.enabled]]`link:#quarkus.camel.main.enabled[quarkus.camel.main.enabled]`
-If `true` all `camel-main` features are enabled; otherwise no `camel-main` features are enabled. See described the xref:user-guide/bootstrap.adoc[Bootstrap] camel-main section of the documentation for more details.
+If `true` all `camel-main` features are enabled; otherwise no `camel-main` features are enabled. See described the link:https://camel.apache.org/camel-quarkus/latest/user-guide/bootstrap.html#_camel_main[Bootstrap] section of Camel Quarkus documentation for more details.
Review comment:
I see, let's remove this part from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org