[GitHub] [arrow] ianmcook commented on a change in pull request #10590: ARROW-12870: [R] Bindings for stringr::str_like

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #10590:
URL: https://github.com/apache/arrow/pull/10590#discussion_r657921373



##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -724,3 +724,67 @@ test_that("errors in strptime", {
     'Time zone argument not supported by Arrow'
   )
 })
+
+test_that("str_like", {
+  
+  df <- tibble(x = c("Foo and bar", "baz and qux and quux"))
+  
+  # This will give an error until a new version of stringr with str_like has been released

Review comment:
       It's probably best to `skip()` this instead of wrapping it in `expect_error()`, that way when the new stringr is released, it won't cause this test to start failing. Could you move it to after the other expectations just below, and add a `skip()` before it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org