[GitHub] [superset] giftig commented on issue #25450: Presto DB regression on 3.0.0

["giftig (via GitHub)" <gi...@apache.org>]

giftig commented on issue #25450:
URL: https://github.com/apache/superset/issues/25450#issuecomment-1742214303

   0.272 is significantly after presto and trino forked, the last common version was 0.215, in 2019. We've already started trying to divide the presto logic from the trino logic, and we're using a different client library now too, so and this feels like a sign we might need to think about completely decoupling them; we'll likely introduce regressions by fixing one and breaking the other, otherwise.
   
   If this logic is currently broken on several presto versions we probably need to fork it, drop it from `PrestoDbBaseSpec` and move it to the trino one instead, and either reinstate an old version to the `PrestoDbSpec` or start from scratch (or probably a bit of both, start from an old version which seems to work and raise further issues from there).
   
   It's unfortunate how much logic will end up forked / duplicated this way but it's probably unavoidable since presto/trino is forked itself, especially if we're seeing issues like timestamps having different expected precisions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org