You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@directory.apache.org by fe...@apache.org on 2010/05/18 05:59:19 UTC

svn commit: r945483 - /directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java

Author: felixk
Date: Tue May 18 03:59:19 2010
New Revision: 945483

URL: http://svn.apache.org/viewvc?rev=945483&view=rev
Log:
Findbugs
This toString method seems to return null in some circumstances. A liberal reading of the spec could be interpreted as allowing this, but it is probably a bad idea and could cause other code to break. Return the empty string or some other appropriate string rather than null. 

Modified:
    directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java

Modified: directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java?rev=945483&r1=945482&r2=945483&view=diff
==============================================================================
--- directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java (original)
+++ directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java Tue May 18 03:59:19 2010
@@ -567,7 +567,7 @@ public class LdifEntry implements Clonea
         }
         catch ( LdapException ne )
         {
-            return null;
+            return "";
         }
     }