You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2024/05/13 04:33:32 UTC
[PR] wamr: Add a few options for esp32s3 [nuttx-apps]
yamt opened a new pull request, #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385
## Summary
The corresponding WAMR change:
https://github.com/bytecodealliance/wasm-micro-runtime/pull/2348
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1598218966
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
please remove esp32s3 specific code from wamr and remove ARCH_CHIP_ESP32S3 from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1598048603
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
why check ARCH_CHIP_ESP32S3 in common code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1598218966
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
so, please remove esp32s3 specific code from wamr and remove ARCH_CHIP_ESP32S3 from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1599215041
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
i'm not happy with the current structure either.
but i want to make it work first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1599400345
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
can we remove ARCH_CHIP_ESP32S3 from patch? espressif is working on to make the change in wamr more general for other arch/chip too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1599406623
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
ok. done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] wamr: Add a few options for esp32s3 [nuttx-apps]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #2385:
URL: https://github.com/apache/nuttx-apps/pull/2385#discussion_r1598073630
##########
interpreters/wamr/Kconfig:
##########
@@ -47,6 +47,16 @@ config INTERPRETERS_WAMR_AOT_QUICK_ENTRY
signature.
Enable this option will increase the size of runtime, ~8KB.
+config INTERPRETERS_WAMR_AOT_WORD_ALIGN_READ
+ bool "Make WAMR AOT loader use word-aligned read"
+ default y
+ depends on INTERPRETERS_WAMR_AOT && ARCH_CHIP_ESP32S3
Review Comment:
because these things in wamr are specific to esp32s3 at least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org