[GitHub] [arrow] kou commented on pull request #34765: GH-14917: [C++] Error out when GTest is compiled with a C++ standard lower than 17

["kou (via GitHub)" <gi...@apache.org>]

kou commented on PR #34765:
URL: https://github.com/apache/arrow/pull/34765#issuecomment-1496936467

   We use `INTERFACE_COMPILE_FEATURES` for this approach but it's not perfect because GoogleTest always sets `cxx_std_14` (or `cxx_std_11` in older Google Test): https://github.com/google/googletest/blob/7ee260c54921571b18b15049304426fe151c1265/googletest/cmake/internal_utils.cmake#L204
   
   But GoogleTest may be built with C++17 even when `INTERFACE_COMPILE_FEATURES` is `cxx_std_14` or `cxx_std_11`.
   It's occurred when C++ compiler uses C++17 by default. (Recent Linux distributions will use `g++` that uses C++17 by default.)
   
   I'll implement #34813. Please wait for a few days.
   
   FYI: We need a GoogleTest that uses https://github.com/google/googletest/blob/7ee260c54921571b18b15049304426fe151c1265/googletest/include/gtest/internal/gtest-port.h#L2470-L2482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org