[GitHub] [airflow] fenglu-g commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR

[GitBox <gi...@apache.org>]

fenglu-g commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#discussion_r281813058
 
 

 ##########
 File path: airflow/contrib/operators/dataproc_operator.py
 ##########
 @@ -272,7 +307,7 @@ def _wait_for_done(self, service):
                 time.sleep(15)
 
     def _get_init_action_timeout(self):
-        match = re.match(r"^(\d+)(s|m)$", self.init_action_timeout)
+        match = re.match(r"^(\d+)([sm])$", self.init_action_timeout)
 
 Review comment:
   just double check, should the regex pattern be [smdh] as well to be consistent with the get_graceful_decommission_timeout? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services