[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4418: ARTEMIS-4206 Adding debug support for large messages not being removed

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1155119030


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/LargeServerMessage.java:
##########
@@ -27,6 +27,8 @@
 
 public interface LargeServerMessage extends ReplicatedLargeMessage {
 
+   boolean DEBUG = Boolean.parseBoolean(System.getProperty("ARTEMIS_LARGE_MESSAGE_DEBUG", "false"));

Review Comment:
   I will just use logger.isDebugEnabled();
   
   if RefCountMessage.logger is debug, it will be using debug
   
   
   Maybe I will also expose the logger from RefCountMessage with RefCountMessage::isDebugEnabled()
   
   As I will be adding a method refCountMessage.addDebug(String );
   
   (Not sure I will keep this method in the final version after I figure out the issue I'm dealing with now...
     apparently a message could be duplicated after a failed AMQP Consumer in some weird race, and if I add logger.debug() the error is gone... the only way I have been able to capture this was by adding a new event to the debugState, and checking if I'm trying to remove the message twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org