You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2010/02/15 20:57:28 UTC

[jira] Created: (AVRO-416) ivy maven install should also install -sources.jar as well

ivy maven install should also install -sources.jar as well
----------------------------------------------------------

                 Key: AVRO-416
                 URL: https://issues.apache.org/jira/browse/AVRO-416
             Project: Avro
          Issue Type: Bug
          Components: java
    Affects Versions: 1.2.0
            Reporter: ryan rawson
             Fix For: 1.3.0
         Attachments: AVRO-416.patch

When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834000#action_12834000 ] 

ryan rawson commented on AVRO-416:
----------------------------------

the current build scripts do not built the jar into the 'dist' directory, but into the build directory, and my patch drops the -sources.jar along side the binary-only jar. So a minor update to the wiki to also copy the -sources.jar out there would fix this for all time.

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834012#action_12834012 ] 

Doug Cutting commented on AVRO-416:
-----------------------------------

> the current build scripts do not built the jar into the 'dist' directory

They should.  All artifacts we intend to distribute as part of a release should be pushed up to the top-level dist/ directory.  The wiki will need to be updated for the next release, since it pre-dates AVRO-163, when release artifacts were still in the top-level build/.

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated AVRO-416:
-----------------------------

    Attachment: AVRO-416.patch

this publishes sources.jar to local disk, but I didn't see a remote repo publish, so I'm not sure how it would get out there.

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833997#action_12833997 ] 

Doug Cutting commented on AVRO-416:
-----------------------------------

We currently push things to the Maven repo with scp, as described in http://wiki.apache.org/hadoop/Avro/HowToRelease.  The build should put the source jar into the top-level dist/ directory.  Then whoever does the release can push it to Maven.

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-416:
------------------------------

      Resolution: Fixed
        Assignee: ryan rawson
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.  I also added the source jar to the distribution.  Since there are so many java-specific files in the distribution, I also moved them to a separate subdirectory.

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-416) ivy maven install should also install -sources.jar as well

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated AVRO-416:
-----------------------------

    Status: Patch Available  (was: Open)

> ivy maven install should also install -sources.jar as well
> ----------------------------------------------------------
>
>                 Key: AVRO-416
>                 URL: https://issues.apache.org/jira/browse/AVRO-416
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>            Reporter: ryan rawson
>             Fix For: 1.3.0
>
>         Attachments: AVRO-416.patch
>
>
> When we do ant mvn-install, we don't get a -sources.jar to go along with the binary jar.  If we publish a sources jar, most IDE integration will attach the sources (as a maven option) so users can get the code along with their binaries and help them understand avro more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.