You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Jean-Christophe Kermagoret (JIRA)" <ji...@apache.org> on 2005/12/28 07:21:31 UTC
[jira] Created: (COCOON-1727) CForms do not allow anymore dots '.' in widget id
CForms do not allow anymore dots '.' in widget id
-------------------------------------------------
Key: COCOON-1727
URL: http://issues.apache.org/jira/browse/COCOON-1727
Project: Cocoon
Type: Bug
Components: Blocks: Forms
Reporter: Jean-Christophe Kermagoret
Priority: Blocker
I just can't use my forms anymore in 2.2 version because I use dots in my widget id. Unfortunately, I usually use the widget id to create the corresponding xml element name, and xml element names may contain dots '.'
The code in AbstractDefinitionBuilder says it does not permit '.' because of path conflicts. Is it true, and in that case in which part of the code ? Or is it just a precaution ? This may oblige developers to change a lot of things in their forms and code related, which is not a very good news :-( if they want to use 2.2
I should suggest to remove the dot test, or to add compatibility test, that should permit to keep the old naming scheme.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Skomentowane: (COCOON-1727) CForms do not allow anymore dots '.' in widget id
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1727?page=comments#action_12361315 ]
Grzegorz Kossakowski (aka g[R]eK) commented on COCOON-1727:
-----------------------------------------------------------
Actually, Forms block is unstable and this incompatibility change is acceptable. Moreover, it was discussed and justified see [1] and [2]. I think the only way is to map your element names into widget ids differently or change them. I know it may be hard task, but revert of this change prevents developers from working on futher development of forms block. This is _my_ point of view and ask on dev maillist if you wish.
[1] http://news.gmane.org/find-root.php?group=gmane.text.xml.cocoon.devel&article=57851
[2] http://news.gmane.org/find-root.php?group=gmane.text.xml.cocoon.devel&article=57666
> CForms do not allow anymore dots '.' in widget id
> -------------------------------------------------
>
> Key: COCOON-1727
> URL: http://issues.apache.org/jira/browse/COCOON-1727
> Project: Cocoon
> Type: Bug
> Components: Blocks: Forms
> Reporter: Jean-Christophe Kermagoret
> Priority: Blocker
>
> I just can't use my forms anymore in 2.2 version because I use dots in my widget id. Unfortunately, I usually use the widget id to create the corresponding xml element name, and xml element names may contain dots '.'
> The code in AbstractDefinitionBuilder says it does not permit '.' because of path conflicts. Is it true, and in that case in which part of the code ? Or is it just a precaution ? This may oblige developers to change a lot of things in their forms and code related, which is not a very good news :-( if they want to use 2.2
> I should suggest to remove the dot test, or to add compatibility test, that should permit to keep the old naming scheme.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1727) CForms do not allow anymore dots '.' in widget id
Posted by "Jean-Christophe Kermagoret (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1727?page=comments#action_12361316 ]
Jean-Christophe Kermagoret commented on COCOON-1727:
----------------------------------------------------
I don't understand very well the rules that make things stable or unstable.
Ok, I'm using CForms for 2 years now (woody included) and I may understand what is saying above. But, I suggest to provide a compatibility workaround that permits to avoid to change code for people who consider CForms block stable enough.
For example, we could imagine a compatibility attribute in the widget definition that permit to avoid the test I mentioned above.
<fd:field id="fake.dtstart" compatibility="old-naming-scheme">
...
If you agree, I will be happy to provide the corresponding patch.
> CForms do not allow anymore dots '.' in widget id
> -------------------------------------------------
>
> Key: COCOON-1727
> URL: http://issues.apache.org/jira/browse/COCOON-1727
> Project: Cocoon
> Type: Bug
> Components: Blocks: Forms
> Reporter: Jean-Christophe Kermagoret
> Priority: Blocker
>
> I just can't use my forms anymore in 2.2 version because I use dots in my widget id. Unfortunately, I usually use the widget id to create the corresponding xml element name, and xml element names may contain dots '.'
> The code in AbstractDefinitionBuilder says it does not permit '.' because of path conflicts. Is it true, and in that case in which part of the code ? Or is it just a precaution ? This may oblige developers to change a lot of things in their forms and code related, which is not a very good news :-( if they want to use 2.2
> I should suggest to remove the dot test, or to add compatibility test, that should permit to keep the old naming scheme.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1727) CForms do not allow anymore dots '.'
in widget id
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1727?page=all ]
Jean-Baptiste Quenot closed COCOON-1727:
----------------------------------------
Resolution: Invalid
There is a vote on cocoon-dev to mark CForms stable. Closing this issue. See http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=113716641308237&w=2
To workaround the problem, simply remove the forbidden character in your form widget's name.
> CForms do not allow anymore dots '.' in widget id
> -------------------------------------------------
>
> Key: COCOON-1727
> URL: http://issues.apache.org/jira/browse/COCOON-1727
> Project: Cocoon
> Type: Bug
> Components: Blocks: Forms
> Reporter: Jean-Christophe Kermagoret
> Priority: Blocker
>
> I just can't use my forms anymore in 2.2 version because I use dots in my widget id. Unfortunately, I usually use the widget id to create the corresponding xml element name, and xml element names may contain dots '.'
> The code in AbstractDefinitionBuilder says it does not permit '.' because of path conflicts. Is it true, and in that case in which part of the code ? Or is it just a precaution ? This may oblige developers to change a lot of things in their forms and code related, which is not a very good news :-( if they want to use 2.2
> I should suggest to remove the dot test, or to add compatibility test, that should permit to keep the old naming scheme.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira