[GitHub] [httpcomponents-client] careylam commented on a change in pull request #283: Fix the issues causing Kerberos/SPNego to fail

[GitBox <gi...@apache.org>]

careylam commented on a change in pull request #283:
URL: https://github.com/apache/httpcomponents-client/pull/283#discussion_r574852266



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/auth/KerberosConfig.java
##########
@@ -81,6 +85,10 @@ public Option getRequestDelegCreds() {
         return requestDelegCreds;
     }
 
+    public String getServiceName() {

Review comment:
       Agree! Ideally we can just hardcode it in the code like what v4.5 does. This code is written just in case there's a plan to support other type. Please suggest. 
   
   Kerberos/SPNego works with these changes. Otherwise, not




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org