[GitHub] [bookkeeper] zymap commented on a diff in pull request #3918: Fix isWritable incorrect problem.

["zymap (via GitHub)" <gi...@apache.org>]

zymap commented on code in PR #3918:
URL: https://github.com/apache/bookkeeper/pull/3918#discussion_r1168091521


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1097,7 +1097,7 @@ private void closeInternal(boolean permanent, boolean wait) {
             }
             toClose = channel;
             channel = null;
-            makeWritable();
+            makeUnWritable();

Review Comment:
   The writable should be a reflection value of the Channel's isWritable. So we make it default to true. So it should always be true except when the channel is non-writable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org