You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "yigress (via GitHub)" <gi...@apache.org> on 2023/02/03 02:02:21 UTC
[GitHub] [hive] yigress opened a new pull request, #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
yigress opened a new pull request, #4014:
URL: https://github.com/apache/hive/pull/4014
### What changes were proposed in this pull request?
HIVE-26771 is done for hive-iceberg, move createTable DDLTask ahead of TezTask can benefit other types of StorageHandler as well for CTAS. This is to partially backport HIVE-26771 (not the hive-iceberg part)
### Why are the changes needed?
To support CTAS for StorageHandler.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
no change on default behavior. tested with custom storagehandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao merged PR #4014:
URL: https://github.com/apache/hive/pull/4014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #4014:
URL: https://github.com/apache/hive/pull/4014#issuecomment-1426554151
Merged, thanks @yigress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on PR #4014:
URL: https://github.com/apache/hive/pull/4014#issuecomment-1418713588
@yigress
Your patch looks good to me but I have some comments:
1. Could you please check if the 26 failing test caused by this patch?
2. Have you tested whether the table is dropped in case of any error while executing the query in the ctas statement or cancelled by the user?
In case of Iceberg it is handled by [HiveIcebergQueryLifeTimeHook]( https://github.com/apache/hive/blob/513127dd7793bee5caccbd266aa81d6bf6299902/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergQueryLifeTimeHook.java#L60)
and set via
```
set hive.query.lifetime.hooks=org.apache.iceberg.mr.hive.HiveIcebergQueryLifeTimeHook;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4014:
URL: https://github.com/apache/hive/pull/4014#issuecomment-1423141357
@kasakrisz can you bless this? we have storagehandler that can't wait till hive-4, so this can greatly help users in hive-3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4014:
URL: https://github.com/apache/hive/pull/4014#issuecomment-1416255051
@kasakrisz can you review this partial backport of your work in HIVE-26771? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yigress commented on pull request #4014: HIVE-27017: backport HIVE-26771 option to use createTable DDLTask in …
Posted by "yigress (via GitHub)" <gi...@apache.org>.
yigress commented on PR #4014:
URL: https://github.com/apache/hive/pull/4014#issuecomment-1419735482
Thank you @kasakrisz for review and sharing the info on how the failure is handled in hive-iceberg! The tests failures are unrelated, they been failing in other PRs for a while and they are not CTAS related either. Could you kindly merge this PR too? This simplifies a lot how storagehandler supports CTAS. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org