[GitHub] [incubator-nuttx] adamkaliszan commented on pull request #6378: SSD1680 e-ink driver

[GitBox <gi...@apache.org>]

adamkaliszan commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1148864253

   @acassis Thx for Your remarks. 
   I was wondering if split it into two commits or no. The reason, why I decided to pull all together was testing possibility.
   I can split it into two commits. I have some questions
   
   1) Current implementation of driver was not tested on 3 color displays. Portrait mode with 3 colors should work. Landscape mode with 3 colors is not implemented (more complicated bit stripping). I decided to add #error macro in order to inform that some modes are not implemented.
   What should I do with the code for 3 color displays. Remove it or leave in current state? Maybe I should remove options with 3 color displays in Kconfig file?
   
   2) Using E-Ink display has a little bit different philosophy in comparison to LCD or OLED. There is special command that redraw the screen. This operation is time consuming (about 1s) and energy consuming. Now display redraw content after changing the last row. I would like to add special IOCLT command or use the existing one, that as argument takes area. Area with width and height 0 determine, that we want to redraw screen. I didn't want to add driver that have an impact on using frame buffer. Is it acceptable in first version?
   
   3) Missing library for coping bits, like memcopy for coping the bytes. Now special functions are in driver file. Is it acceptable?
   
   4) There are 5 very similar functions ssd1680_snd_cmd_with_data0 .. ssd1680_snd_cmd_with_data4. I wanted to avoid using vargs macros. Is it acceptable or replace it by one function with variable number of arguments?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org