You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kexianjun (GitHub)" <gi...@apache.org> on 2019/02/15 09:15:21 UTC

[GitHub] [incubator-dubbo-ops] kexianjun opened pull request #306: fix 305

fix #305 

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/306 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #306: fix 305

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=h1) Report
> Merging [#306](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/45c0d4181eebfeed656e8c8f695e78bdee4a2762?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `20%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #306      +/-   ##
=============================================
- Coverage      19.38%   19.29%   -0.09%     
  Complexity       289      289              
=============================================
  Files             91       91              
  Lines           3637     3638       +1     
  Branches         566      566              
=============================================
- Hits             705      702       -3     
- Misses          2857     2861       +4     
  Partials          75       75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvR2VuZXJpY1NlcnZpY2VJbXBsLmphdmE=) | `38.88% <20%> (-19.94%)` | `2 <0> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=footer). Last update [45c0d41...c1570d4](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/306 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #306: fix 305

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/306 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #306: fix 305

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=h1) Report
> Merging [#306](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/45c0d4181eebfeed656e8c8f695e78bdee4a2762?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `25%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop    #306      +/-   ##
============================================
- Coverage      19.38%   19.3%   -0.09%     
+ Complexity       289     288       -1     
============================================
  Files             91      91              
  Lines           3637    3637              
  Branches         566     566              
============================================
- Hits             705     702       -3     
- Misses          2857    2860       +3     
  Partials          75      75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvR2VuZXJpY1NlcnZpY2VJbXBsLmphdmE=) | `41.17% <25%> (-17.65%)` | `2 <0> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=footer). Last update [45c0d41...18baac6](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/306 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #306: fix 305

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=h1) Report
> Merging [#306](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/45c0d4181eebfeed656e8c8f695e78bdee4a2762?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `20%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #306      +/-   ##
=============================================
- Coverage      19.38%   19.29%   -0.09%     
  Complexity       289      289              
=============================================
  Files             91       91              
  Lines           3637     3638       +1     
  Branches         566      566              
=============================================
- Hits             705      702       -3     
- Misses          2857     2861       +4     
  Partials          75       75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvR2VuZXJpY1NlcnZpY2VJbXBsLmphdmE=) | `38.88% <20%> (-19.94%)` | `2 <0> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=footer). Last update [45c0d41...c1570d4](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/306 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org