You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/13 15:40:21 UTC
[GitHub] [fineract] vorburger opened a new pull request #757: escape all
`grouping` in SQL files for MySQL 8 compatibility
vorburger opened a new pull request #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757
Indirectly related to FINERACT-762 - not sure if strictly required, but seems like a good idea anyway at this opportunity, so why not.
As originally on https://github.com/apache/fineract/pull/638/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-613046487
This failed due to what #762 will fix (work around, deactivating test); let's rebase this once that is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615485628
Post Merge Travis Check fail: https://travis-ci.org/github/apache/fineract/builds/676407979
Anyone know why? Something might be broken somewhere..Something critical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum closed pull request #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615489434
> > I started this, during my testing it seems to work fine (CRUD operations over entities) but i think it need to be tested deeply to be shure that nothing is break. One little observation, in when you specify the schema name in the query, you need to add the string ?serverTimezone=UTC this in in files: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java line 51
> > 
> > and I created he file fineract-provider/src/main/resources/sql/migrations/list_db/V1_2__updated_connection_string_option.sql
> > 
> > Originally in #638
>
> Thanks @nemux , Do you want to pick up from this merged PR..and add the required changes to make this work. We will greatly appreciate that. See: https://issues.apache.org/jira/browse/FINERACT-897
>
> Also join the mailing list of Fineract and Mifos: https://mifos.org/resources/community/communications/ so we communicate there.
ALso, we cannot completely switch to MySQL JDBC Driver because of License issues... there is a work around proposed here: https://github.com/apache/fineract/pull/760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum merged pull request #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] nemux commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
nemux commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615943307
Sure, let me work no that
El sáb., 18 de abril de 2020 11:46, Michael Vorburger ⛑️ <
notifications@github.com> escribió:
> @nemux <https://github.com/nemux> could you engage on
> https://issues.apache.org/jira/browse/FINERACT-901 on the TZ thing?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/757#issuecomment-615901773>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA3Z24UEIX4IURFZH7EGUWLRNHKOTANCNFSM4MHBEPNQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger opened a new pull request #757: escape all
`grouping` in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger opened a new pull request #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757
Indirectly related to https://issues.apache.org/jira/browse/FINERACT-762 - not sure if strictly required, but seems like a good idea anyway at this opportunity, so why not.
As originally on https://github.com/apache/fineract/pull/638/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615479171
> > > will this work as it is with MySQL 8.0 and above or we still need some other code changes?
> >
> >
> > I've actually no idea, I just found it on https://github.com/apache/fineract/pull/638/files and it seemed like a good idea!
>
> Want to switch MySQL version on Travis to 8.0 and see?...Just curious...MySQL 5.5 to 5.7 support is great. Maybe an experiment for another day.
@xurror , @thesmallstar , @percyashu ..Anyone has time to play around with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] nemux commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
nemux commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615488050
I started this, during my testing it seems to work fine (CRUD operations over entities) but i think it need to be tested deeply to be shure that nothing is break. One little observation, in when you specify the schema name in the query, you need to add the string ?serverTimezone=UTC this in in files: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java line 51
and I created he file fineract-provider/src/main/resources/sql/migrations/list_db/V1_2__updated_connection_string_option.sql
Originally in https://github.com/apache/fineract/pull/638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615478574
> > will this work as it is with MySQL 8.0 and above or we still need some other code changes?
>
> I've actually no idea, I just found it on https://github.com/apache/fineract/pull/638/files and it seemed like a good idea!
Want to switch MySQL version on Travis to 8.0 and see?...Just curious...MySQL 5.5 to 5.7 support is great. Maybe an experiment for another day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615401708
@awasum review and merge this one? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615363539
This failed to build again, due to flaky test which #761 will comment out...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615477663
> will this work as it is with MySQL 8.0 and above or we still need some other code changes?
I've actually no idea, I just found it on https://github.com/apache/fineract/pull/638/files and it seemed like a good idea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615901773
@nemux could you engage on https://issues.apache.org/jira/browse/FINERACT-901 on the TZ thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615488862
> I started this, during my testing it seems to work fine (CRUD operations over entities) but i think it need to be tested deeply to be shure that nothing is break. One little observation, in when you specify the schema name in the query, you need to add the string ?serverTimezone=UTC this in in files: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java line 51
>
> 
>
> and I created he file fineract-provider/src/main/resources/sql/migrations/list_db/V1_2__updated_connection_string_option.sql
>
> 
>
> Originally in #638
Thanks @nemux , Do you want to pick up from this merged PR..and add the required changes to make this work. We will greatly appreciate that. See: https://issues.apache.org/jira/browse/FINERACT-897
Also join the mailing list of Fineract and Mifos: https://mifos.org/resources/community/communications/ so we communicate there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #757: escape all `grouping` in
SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-613933788
#764 has been merged. lets run this or rebase with develop and see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #757: escape all `grouping`
in SQL files for MySQL 8 compatibility
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #757: escape all `grouping` in SQL files for MySQL 8 compatibility
URL: https://github.com/apache/fineract/pull/757#issuecomment-615483358
I've created https://issues.apache.org/jira/browse/FINERACT-897 re. MySQL v8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services