You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/26 07:53:43 UTC
[GitHub] codecov-io edited a comment on issue #6721: [WIP] Timestamp hackery
codecov-io edited a comment on issue #6721: [WIP] Timestamp hackery
URL: https://github.com/apache/incubator-superset/pull/6721#issuecomment-455945732
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=h1) Report
> Merging [#6721](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a62a8d3d985ed7343fe83540e5cdcbb1474ac6ac?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6721 +/- ##
==========================================
+ Coverage 56.07% 56.12% +0.05%
==========================================
Files 525 521 -4
Lines 23220 23174 -46
Branches 2777 2769 -8
==========================================
- Hits 13020 13006 -14
+ Misses 9791 9759 -32
Partials 409 409
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.94% <0%> (-0.15%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.4% <100%> (ø)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `63.06% <0%> (-0.1%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.46% <0%> (-0.09%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.66% <0%> (-0.04%)` | :arrow_down: |
| [...ts/src/visualizations/presets/LegacyChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL0xlZ2FjeUNoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `66.66% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/query/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9pbmRleC50cw==) | `100% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/query/buildQueryObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9idWlsZFF1ZXJ5T2JqZWN0LnRz) | `100% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0hvdGtleXMuanN4) | `100% <0%> (ø)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-superset/pull/6721/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=footer). Last update [a62a8d3...3394f9e](https://codecov.io/gh/apache/incubator-superset/pull/6721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org