[GitHub] [trafficserver] bryancall commented on a change in pull request #7226: Bugfix: set a default inactivity timeout only if a read or write I/O operation was set

[GitBox <gi...@apache.org>]

bryancall commented on a change in pull request #7226:
URL: https://github.com/apache/trafficserver/pull/7226#discussion_r497067124



##########
File path: iocore/net/UnixNet.cc
##########
@@ -70,7 +70,10 @@ class InactivityCop : public Continuation
       }
 
       // set a default inactivity timeout if one is not set
-      if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0) {
+      // The event `EVENT_INACTIVITY_TIMEOUT` only be triggered if a read
+      // or write I/O operation was set by `do_io_read()` or `do_io_write()`.
+      if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0 &&

Review comment:
       I am seeing cases where default_inactivity_timeout is being set on server sessions when ne->read.enabled and ne->write.enabled are 0.  I haven't tracked down if that is required or not for closing the server sessions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org