You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2006/07/10 04:43:29 UTC
[jira] Created: (LANG-272) Minor build and checkstyle changes
Minor build and checkstyle changes
----------------------------------
Key: LANG-272
URL: http://issues.apache.org/jira/browse/LANG-272
Project: Commons Lang
Type: Bug
Versions: Nightly Builds
Reporter: Niall Pemberton
Priority: Minor
Attaching a patch for minor changes to the build:
1) Change project.properties so that the source distro unpacks to a different directory
2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
3) Remove the exclusion of the "text" package from the source distro
4) Include the NOTICE.txt in the maven generated binary distro (and jar)
Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (LANG-272) Minor build and checkstyle changes
Posted by "Stephen Colebourne (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420181 ]
Stephen Colebourne commented on LANG-272:
-----------------------------------------
I'm not sure why we have the old release notes files hanging around. IMHO they should be deleted from svn not included in the release.
On the text package issue, we should be including it in the release, both bin and src
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jira] Commented: (LANG-272) Minor build and checkstyle changes
Posted by James Carman <ja...@carmanconsulting.com>.
Sorry, I replied to the wrong email. Oops.
-----Original Message-----
From: James Carman [mailto:james@carmanconsulting.com]
Sent: Tuesday, July 11, 2006 7:14 AM
To: 'Jakarta Commons Developers List'
Subject: RE: [jira] Commented: (LANG-272) Minor build and checkstyle changes
Oh, by the way, if there are any ambitious folks out there using the
tapestry-acegi (or tapernate for that matter) modules and you want to
provide some documentation, feel free to drop me a patch via mail and I'd be
glad to merge it in.
-----Original Message-----
From: Niall Pemberton (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, July 11, 2006 1:42 AM
To: commons-dev@jakarta.apache.org
Subject: [jira] Commented: (LANG-272) Minor build and checkstyle changes
[
http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420221
]
Niall Pemberton commented on LANG-272:
--------------------------------------
Old release notes can be useful if you're thinking of upgrading or need to
upgrade because of a bug - anyway I'll leave it up to you lang devs to
decide.
I've removed the remaining bits that were put in to exclude the
"org.apache.commons.lang.text" package from version 2.1
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a
different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the
source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release
process - I still think the maven generated binary distro should include the
NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jira] Commented: (LANG-272) Minor build and checkstyle changes
Posted by James Carman <ja...@carmanconsulting.com>.
Oh, by the way, if there are any ambitious folks out there using the
tapestry-acegi (or tapernate for that matter) modules and you want to
provide some documentation, feel free to drop me a patch via mail and I'd be
glad to merge it in.
-----Original Message-----
From: Niall Pemberton (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, July 11, 2006 1:42 AM
To: commons-dev@jakarta.apache.org
Subject: [jira] Commented: (LANG-272) Minor build and checkstyle changes
[
http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420221
]
Niall Pemberton commented on LANG-272:
--------------------------------------
Old release notes can be useful if you're thinking of upgrading or need to
upgrade because of a bug - anyway I'll leave it up to you lang devs to
decide.
I've removed the remaining bits that were put in to exclude the
"org.apache.commons.lang.text" package from version 2.1
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a
different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the
source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release
process - I still think the maven generated binary distro should include the
NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420221 ]
Niall Pemberton commented on LANG-272:
--------------------------------------
Old release notes can be useful if you're thinking of upgrading or need to upgrade because of a bug - anyway I'll leave it up to you lang devs to decide.
I've removed the remaining bits that were put in to exclude the "org.apache.commons.lang.text" package from version 2.1
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Niall Pemberton updated LANG-272:
---------------------------------
Attachment: (was: commons-lang-2.2-checkstyle)
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=comments#action_12420045 ]
Niall Pemberton commented on LANG-272:
--------------------------------------
I've committed the JavaDoc/Checkstyle changes and 1, 2 and 4.
Wrt to 3 ("Remove the exclusion of the "text" package from the source distro") - looks like the target 'dist-build-2.1' should be removed. If we don't remove the exclusion in maven.xml and the "dist-build" target is used to build lang 2.2 then it will mean that the binary distro includes classes which are missing from the source distro.
http://svn.apache.org/viewvc?view=rev&revision=209004
Anyway I'll leave it up to you as I'm not a lang dev - just trying to be pro-active and get my nitpicks in before a RC was done, rather than after :-)
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (LANG-272) Minor build and checkstyle changes
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Henri Yandell resolved LANG-272.
--------------------------------
Resolution: Fixed
Release notes removed.
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
>
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (LANG-272) Minor build and checkstyle changes
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Henri Yandell updated LANG-272:
-------------------------------
Fix Version: 2.2
1, 2 and 4 look good. As do the checkstyle changes. Feel free to commit if you want, otherwise I'll hit them at some point.
3 is changing a target called 'dist-build-2.1'. Either we shoud leave it as it is, or remove the target itself.
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 2.2
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Niall Pemberton updated LANG-272:
---------------------------------
Attachment: (was: commons-lang-2.2-build)
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Niall Pemberton updated LANG-272:
---------------------------------
Attachment: commons-lang-2.2-build
commons-lang-2.2-checkstyle
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: commons-lang-2.2-build, commons-lang-2.2-checkstyle
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (LANG-272) Minor build and checkstyle changes
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/LANG-272?page=all ]
Niall Pemberton updated LANG-272:
---------------------------------
Attachment: commons-lang-2.2-build.txt
commons-lang-2.2-checkstyle.txt
> Minor build and checkstyle changes
> ----------------------------------
>
> Key: LANG-272
> URL: http://issues.apache.org/jira/browse/LANG-272
> Project: Commons Lang
> Type: Bug
> Versions: Nightly Builds
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: commons-lang-2.2-build.txt, commons-lang-2.2-checkstyle.txt
>
> Attaching a patch for minor changes to the build:
> 1) Change project.properties so that the source distro unpacks to a different directory
> 2) Include checkstyle.properties and all the RELEASE-NOTES files in the source distro
> 3) Remove the exclusion of the "text" package from the source distro
> 4) Include the NOTICE.txt in the maven generated binary distro (and jar)
> Althought the ant build is used to create the binary distro in the release process - I still think the maven generated binary distro should include the NOTICE.txt
> Also attaching a patch to clean up the few minor checkstyle issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org