You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Tao Li (Jira)" <ji...@apache.org> on 2022/05/12 03:12:00 UTC

[jira] [Created] (HBASE-27026) Disable Style/FrozenStringLiteralComment for ruby

Tao Li created HBASE-27026:
------------------------------

             Summary: Disable Style/FrozenStringLiteralComment for ruby
                 Key: HBASE-27026
                 URL: https://issues.apache.org/jira/browse/HBASE-27026
             Project: HBase
          Issue Type: Improvement
            Reporter: Tao Li
            Assignee: Tao Li


By default Style/FrozenStringLiteralComment is open in rubocop. If we update a ruby file, rubocop prompts `Missing frozen string literal comment` https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt.

To address this warn, we need to add `# frozen_string_literal: true` to the top of the ruby file, which will be added to the `Apache License` and will look strange.

I don't think this `FrozenStringLiteralComment` check is very necessary. Can we disable it.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)