You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/03/21 05:26:29 UTC

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1605

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................

Remove Extraneous Quotes in Start Sample Batchfile

e.g.
"--------------------------"
"Mon 03/20/2017 19:31:01.81"
"--------------------------"

Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
---
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/05/1605/1

diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
index fce27a9..60f5cb5 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
@@ -102,9 +102,9 @@
 goto :post_timestamp
 
 :timestamp
-echo "--------------------------" >> %1
-echo "%date% %time%" >> %1
-echo "--------------------------" >> %1
+echo -------------------------- >> %1
+echo %date% %time% >> %1
+echo -------------------------- >> %1
 exit /B 0
 
 :post_timestamp

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4765/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Patch Set 1: Code-Review+2

It appears my crusade against the space was a bit overzealous ;)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2262/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has submitted this change and it was merged.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Remove Extraneous Quotes in Start Sample Batchfile

e.g.
"--------------------------"
"Mon 03/20/2017 19:31:01.81"
"--------------------------"

Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1605
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
BAD: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
---
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
index fce27a9..60f5cb5 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
@@ -102,9 +102,9 @@
 goto :post_timestamp
 
 :timestamp
-echo "--------------------------" >> %1
-echo "%date% %time%" >> %1
-echo "--------------------------" >> %1
+echo -------------------------- >> %1
+echo %date% %time% >> %1
+echo -------------------------- >> %1
 exit /B 0
 
 :post_timestamp

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/87/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Remove Extraneous Quotes in Start Sample Batchfile

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Remove Extraneous Quotes in Start Sample Batchfile
......................................................................


Patch Set 1:

BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/854/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24581eb36e193628b93cb5be52903beb206c603d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No