[GitHub] mikewalch commented on a change in pull request #777: Remove hard coded values from BatchWriterConfig

[GitBox <gi...@apache.org>]

mikewalch commented on a change in pull request #777: Remove hard coded values from BatchWriterConfig
URL: https://github.com/apache/accumulo/pull/777#discussion_r235559247
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java
 ##########
 @@ -209,15 +231,15 @@ public void write(DataOutput out) throws IOException {
     // write this out in a human-readable way
     ArrayList<String> fields = new ArrayList<>();
     if (maxMemory != null)
-      addField(fields, "maxMemory", maxMemory);
+      addField(fields, MAX_MEM.getKey(), maxMemory);
 
 Review comment:
   Could leave this method unchanged.  Not sure if there is a benefit to changing these keys

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services