You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/30 15:37:10 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #4902: Spark-3.2: Support Zorder option for rewrite_data_files stored procedure
rdblue commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r884943466
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderStrategy.java:
##########
@@ -133,6 +133,14 @@ public SparkZOrderStrategy(Table table, SparkSession spark, List<String> zOrderC
"Cannot perform ZOrdering, all columns provided were identity partition columns and cannot be used.");
}
+ zOrderColNames.forEach(col -> {
+ NestedField nestedField = table.schema().caseInsensitiveFindField(col);
Review Comment:
This should use the case sensitivity setting from Spark, rather than always using case insensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org