You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/07/21 08:37:47 UTC
[GitHub] incubator-pirk pull request #17: [PIRK-16] Define XML schema definition file...
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/17
[PIRK-16] Define XML schema definition files for Pirk's data and query schemas
Reading the loader code, the "isArray" element is not optional. Does it make sense and aid readability for me to tweak the loader to assume isArray is false by default? or do you want to keep it explicit?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk pirk-16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 4a88847ecd12cbfd90bcab02575231ba1486aed5
Author: Tim Ellison <t....@gmail.com>
Date: 2016-07-21T08:30:13Z
Define XML schema definition files for Pirk's data and query schemas
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/17
Designating the isArray default to 'false' makes sense. It seems that if we are going to have default values, we should be explicit and also specify 'required' on all attributes that are required. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/17
Each element must occur once (i.e. minOccurs="1" maxOccurs="1") unless stated differently, so we just need to add a minOccurs="0" to isArray to make it optional, defaulting to true, so we can write <isArray/>.
I'll update this PR.
[It is also possible to define the set of allowed values for the <type> element, but since that may contain a class name as well as the primitive types, we can't usefully define it any better in the xsd.]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/17
As well as supporting the original format, this PR allows for a more concise form, like this:
```
<schema>
<schemaName>fakeDataSchema</schemaName>
<element>
<name>elementName1</name>
<type>string</type>
</element>
<element>
<name>elementName2</name>
<type>int</type>
<isArray/>
<partitioner>org.apache.pirk.schema.data.partitioner.PrimitiveTypePartitioner</partitioner>
</element>
<element>
<name>elementName3</name>
<type>string</type>
<isArray/>
<partitioner>org.apache.pirk.schema.data.partitioner.IPDataPartitioner</partitioner>
</element>
</schema>
```
Note: ```elementName1``` has no ```isArray``` element, so it is not an array; the other two don't need to specify a value for ```isArray```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #17: [PIRK-16] Define XML schema definition file...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #17: [PIRK-16] Define XML schema definition files for P...
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/17
+1 Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---