You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/03/07 12:40:09 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5620: Allow to realy NEVER check for updates, even on first start.
sdedic opened a new pull request, #5620:
URL: https://github.com/apache/netbeans/pull/5620
AutoUpdate can be configured to check never for updates, but regardless of that setting, the check happens on 1st startup. For vscode distribution, I would like to ensure the autoupdate really never connects to AU center. At the same time I did not want to affect the NB operation - so I've added a 'branding API' that can be used to disable the first forced check. nbls distribution then contains the appropriate branding that disables it.
Maybe a command will be added later to faciliate with AU to install updates, but given how the vscode Marketplace works, it may not be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net closed pull request #5620: Allow to realy NEVER check for updates, even on first start.
URL: https://github.com/apache/netbeans/pull/5620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1466830306
Hm wrong wording. More precise description would be "an installation (= userdir) that has no information from the AU center". An userdir with cleared caches (var/cache) would qualify - so an imported userdir would qualify as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1466704207
@neilcsmith-net re bug: I thought that it is a bug initially .... but in fact the current behaviour is (with NEVER) to check just once in a completely empty userdir - and then never again. This could be actually beneficial, as it fetches info for a fresh installation. I did not want to interfere with the behaviour.
Do you think the behaviour is really buggy ? If so then clearly simple fix could be better.
Re. removing from vscode distro -- it's not that easy, as `autoupdate.ui` is referenced from `java.source` (for downloading nbjavac), from `org.netbeans.modules.junit` (downloading junit libraries I think), `maven` (downloads apisupport for NBM packaging) and `code.analysis` (code analysis plugins download)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1470533458
> Yes, but I don't think that changes the argument. How can this ever be set to `NEVER` unless explicitly set? And if explicitly set, it seems a bug to ever connect without explicit user action.
>
For example, vscode *brands* the default setting to NEVER. So it is not explicitly set (by the user). It will be also implicitly set by **importing** old settings by a new installation - and this is the case, where it *might* be valid to do one-time fetch.
How to reach a consensus, or a confirmation of the 'bug suspection' here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1466673833
Personally, I would remove the additional branding and fix `NEVER` to mean never in all cases. Ignoring the setting seems like a bug.
If you do want branding to bypass all of the behaviour, should that be one of the flags checked in `Installer`?
It's potentially a shame that this module cannot be left out of VSCode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1466727628
How is an empty userdir going to be set to `NEVER` though? Either it's an imported setting from the user, which should be respected, or it's a branded default of the application, which should also be respected. Or am I missing a scenario?
> Re. removing from vscode distro -- it's not that easy, as `autoupdate.ui` is referenced from `java.source` (for downloading nbjavac), from `org.netbeans.modules.junit` (downloading junit libraries I think), `maven` (downloads apisupport for NBM packaging) and `code.analysis` (code analysis plugins download)
I'm aware. I have the same issue in my platform application, which uses `java.source` etc. and has no need for the update centre checks or UI either. I meant it's a shame there's a hard dependency there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1511038055
> For example, vscode _brands_ the default setting to NEVER. So it is not explicitly set (by the user). It will be also implicitly set by **importing** old settings by a new installation - and this is the case, where it _might_ be valid to do one-time fetch.
If it's branded, it's been explicitly set by the application developer, if imported settings it has been explicitly set at some point by the user. In either case, it seems wrong to ever connect without manual interaction.
This is still marked for NB18. Given the other changes have addressed immediate concerns in VSCode, do you want to adapt this PR for NB18 or NB19, or close it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#discussion_r1133549221
##########
platform/autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/actions/AutoupdateCheckScheduler.java:
##########
@@ -67,6 +69,12 @@
* @author Jiri Rechtacek
*/
public class AutoupdateCheckScheduler {
+ /**
+ * System property that allows to skip forced initial check. If set to true, the check is not forced, if a check was never
+ * was performed - the scheduling is always driven by AU settings.
+ */
+ private static final String INITIAL_CHECK_SKIP_OPT = "autoupdate.initial.check.skip"; // NOI18N
Review Comment:
Fixed in 56895dcc5a8b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1470355758
Yes, but I don't think that changes the argument. How can this ever be set to `NEVER` unless explicitly set? And if explicitly set, it seems a bug to ever connect without explicit user action.
Incidentally, the other bundle needs a license to pass RAT. If it's staying in at all of course! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#discussion_r1127901545
##########
platform/autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/actions/AutoupdateCheckScheduler.java:
##########
@@ -67,6 +69,12 @@
* @author Jiri Rechtacek
*/
public class AutoupdateCheckScheduler {
+ /**
+ * System property that allows to skip forced initial check. If set to true, the check is not forced, if a check was never
+ * was performed - the scheduling is always driven by AU settings.
+ */
+ private static final String INITIAL_CHECK_SKIP_OPT = "autoupdate.initial.check.skip"; // NOI18N
Review Comment:
Leftover after initial system property-based implementation. Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#discussion_r1127896801
##########
platform/autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/actions/AutoupdateCheckScheduler.java:
##########
@@ -67,6 +69,12 @@
* @author Jiri Rechtacek
*/
public class AutoupdateCheckScheduler {
+ /**
+ * System property that allows to skip forced initial check. If set to true, the check is not forced, if a check was never
+ * was performed - the scheduling is always driven by AU settings.
+ */
+ private static final String INITIAL_CHECK_SKIP_OPT = "autoupdate.initial.check.skip"; // NOI18N
Review Comment:
Is it used somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5620: Allow to realy NEVER check for updates, even on first start.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5620:
URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1637609393
@sdedic are we closing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists