You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2020/01/14 15:06:00 UTC

[jira] [Created] (KAFKA-9425) InFlightRequests Class Uses Thread-Safe Counter Non-Thread-Safe Collection

David Mollitor created KAFKA-9425:
-------------------------------------

             Summary: InFlightRequests Class Uses Thread-Safe Counter Non-Thread-Safe Collection
                 Key: KAFKA-9425
                 URL: https://issues.apache.org/jira/browse/KAFKA-9425
             Project: Kafka
          Issue Type: Improvement
            Reporter: David Mollitor


[https://github.com/apache/kafka/blob/d6ace7b2d7c4ad721dd8247fb2b3eff9f67fbfee/clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java#L34-L36]

 

Not sure why this needs the overheard of {{AtomicInteger}} when the collection being modified isn't itself thread-safe.  The comment of the counter says that it may lag as things currently stand.

 

Also, add a few more niceties since I'm opening it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)