[GitHub] [flink] fapaul commented on pull request #18805: [FLINK-26173][streaming] Recover GlobalCommittables with Sink V1 GlobalCommittable serializer

[GitBox <gi...@apache.org>]

fapaul commented on pull request #18805:
URL: https://github.com/apache/flink/pull/18805#issuecomment-1058952216


   > Very thanks @fapaul for the PR!
   > 
   > One main issue from my side is that it seems the behavior of the current `GlobalCommitterOperator` is still not compatible with the legacy one? Currently once the legacy state is restored, in the following execution the behavior of `combine`, `filterRecoveredCommittables` and `endOfInput` is still not called~?
   
   I would have though `combine` and `filterRecoveredCommittables` are now equal or very closely to what was done before.
   
   To be honest I never really understood the idea behind exposing `endOfInput` of the GlobalCommitter. I also have never seen a sink really using it. Can you maybe provide more context here? I would probably make a big warning in the release notes that this `endOfInput` is not used anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org