[jira] [Commented] (HBASE-11007) BLOCKCACHE in schema descriptor seems not aptly named

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000912#comment-14000912 ] 

Hadoop QA commented on HBASE-11007:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12645430/11007.txt
  against trunk revision .
  ATTACHMENT ID: 12645430

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9533//console

This message is automatically generated.

> BLOCKCACHE in schema descriptor seems not aptly named
> -----------------------------------------------------
>
>                 Key: HBASE-11007
>                 URL: https://issues.apache.org/jira/browse/HBASE-11007
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.19
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 11007.txt
>
>
> Hi,
> It seems that setting BLOCKCACHE key to false will disable the Data blocks from being cached but will continue to cache bloom and index blocks. This same property seems to be called cacheDataOnRead inside CacheConfig.
> Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE. We got quite confused and ended up adding our own property CACHE_DATA_ON_READ - we also added some unit tests for the same.
> What do folks think about this ?
> Thanks
> Varun



--
This message was sent by Atlassian JIRA
(v6.2#6252)