You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "EnxDev (via GitHub)" <gi...@apache.org> on 2025/03/28 20:59:04 UTC
[PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
EnxDev opened a new pull request, #32905:
URL: https://github.com/apache/superset/pull/32905
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR migrates the Breadcrumb component from Ant Design v4 to v5, ensuring compatibility with the latest API changes while keeping the implementation as vanilla as possible.
- Upgraded Breadcrumb to use AntD v5.
- Created a story to CSF3 format for better maintainability and compatibility.
- Added a test file to validate the component behavior.
- Kept the implementation minimalistic and close to native AntD usage to reduce unnecessary complexity.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
- Before
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- All tests should pass
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #32905:
URL: https://github.com/apache/superset/pull/32905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039285346
##########
superset-frontend/src/components/Chart/DrillBy/useDrillByBreadcrumbs.tsx:
##########
@@ -26,23 +26,23 @@ import {
styled,
Review Comment:
We were deciding whether to remove the hook or not, since after the refactor the logic has been simplified — there's less code and it's only used here. I'll remove it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2034937065
##########
superset-frontend/src/components/index.ts:
##########
@@ -24,8 +24,11 @@
*/
// TODO: Remove these imports
// eslint-disable-next-line no-restricted-imports
-export { Breadcrumb as AntdBreadcrumb, Checkbox as AntdCheckbox } from 'antd';
-
+export {
+ Checkbox as AntdCheckbox,
+ Collapse as AntdCollapse,
+ Select as AntdSelect,
+} from 'antd';
Review Comment:
### Increasing External UI Library Dependencies <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Direct imports from 'antd' library are increasing despite the codebase's goal to reduce Ant Design dependencies and use custom components.
###### Why this matters
This increases coupling to the Ant Design library, making it harder to maintain consistency, switch UI libraries, or customize components to meet specific needs.
###### Suggested change ∙ *Feature Preview*
Create custom wrapper components for Collapse and Select similar to existing components, following the pattern used for other UI elements:
```typescript
// Create new files like Collapse.tsx and maintain a consistent interface
export { Collapse } from './Collapse';
export { Select } from './Select';
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/12546134-ae02-40ba-969f-17de5b8d76cb)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:054c92b0-4d0b-40df-b22c-0d0e2c887a32 -->
[](054c92b0-4d0b-40df-b22c-0d0e2c887a32)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32905:
URL: https://github.com/apache/superset/pull/32905#issuecomment-2762497202
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
[](258b7efd-db7b-43e0-83e8-e7ab439eff8d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039288881
##########
superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx:
##########
@@ -308,8 +311,35 @@ export default function DrillByModal({
},
[dispatch, drillByConfigs, formData, getFormDataChangesFromConfigs],
);
-
- const breadcrumbs = useDrillByBreadcrumbs(breadcrumbsData, onBreadcrumbClick);
+ const breadcrumbItems = breadcrumbsData
Review Comment:
I think this could have the same answer as [here](https://github.com/apache/superset/pull/32905#discussion_r2039285346), thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2024546515
##########
superset-frontend/src/components/Breadcrumb/Breadcrumb.stories.tsx:
##########
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import type { Meta, StoryObj } from '@storybook/react';
+import { Breadcrumb } from '.';
+
+const meta: Meta<typeof Breadcrumb> = {
+ title: 'Breadcrumb',
+ component: Breadcrumb,
+ tags: ['autodocs'],
+ argTypes: {
+ separator: {
+ control: 'text',
+ description: 'Custom separator between items',
+ defaultValue: '/',
+ },
+ items: {
+ control: 'object',
Review Comment:
Let's use `false` here for the control as it is not really convenient to pass array of items in Storybook and let's use the Storybook table info and summary to provide an example for this prop.
##########
superset-frontend/src/components/Breadcrumb/index.tsx:
##########
@@ -0,0 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Breadcrumb as antdBreadcrumb } from 'antd-v5';
+
+export const Breadcrumb = antdBreadcrumb;
Review Comment:
```suggestion
export const Breadcrumb = AntdBreadcrumb;
```
##########
superset-frontend/src/components/Breadcrumb/index.tsx:
##########
@@ -0,0 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Breadcrumb as antdBreadcrumb } from 'antd-v5';
Review Comment:
```suggestion
import { Breadcrumb as AntdBreadcrumb } from 'antd-v5';
```
##########
superset-frontend/src/components/Breadcrumb/Breadcrumb.stories.tsx:
##########
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import type { Meta, StoryObj } from '@storybook/react';
+import { Breadcrumb } from '.';
+
+const meta: Meta<typeof Breadcrumb> = {
+ title: 'Breadcrumb',
+ component: Breadcrumb,
+ tags: ['autodocs'],
+ argTypes: {
+ separator: {
+ control: 'text',
+ description: 'Custom separator between items',
+ defaultValue: '/',
+ },
+ items: {
+ control: 'object',
+ description: 'List of breadcrumb items',
+ defaultValue: [
+ { title: 'Home', href: '/' },
+ { title: 'Library', href: '/library' },
+ { title: 'Data' },
+ ],
+ },
+ },
+};
+
+export default meta;
+type Story = StoryObj<typeof Breadcrumb>;
+
+export const Default: Story = {
Review Comment:
I see that the component has a bunch of [different abilities](https://ant.design/components/breadcrumb), such as showing a dropdown. It would be nice to have a gallery here of these different abilities. Something like https://superset-storybook.netlify.app/?path=/story/buttongroup--interactive-button-group where we can see multiple components in one view.
##########
superset-frontend/src/components/Breadcrumb/Breadcrumb.test.tsx:
##########
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { Breadcrumb } from '.';
+
+describe('Breadcrumb Component', () => {
+ test('renders breadcrumb items correctly', () => {
+ render(
+ <Breadcrumb>
+ <Breadcrumb.Item>Home</Breadcrumb.Item>
+ <Breadcrumb.Item>Library</Breadcrumb.Item>
+ <Breadcrumb.Item>Data</Breadcrumb.Item>
+ </Breadcrumb>,
+ );
+
+ expect(screen.getByText('Home')).toBeInTheDocument();
Review Comment:
Can we test that also a _**custom**_ divider is present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039294586
##########
superset-frontend/src/components/Alert/Alert.stories.tsx:
##########
@@ -30,7 +30,7 @@ const bigText =
'purus convallis placerat in at nunc. Nulla nec viverra augue.';
export default {
- title: 'Alert',
+ title: 'Components/Alert',
Review Comment:
> I think it looks better this way too. But if we start doing this it should be standardized as well. cc @geido
For now, I don't think there's a clear convention. Previously, some components were inside the components folder and others outside, without really following a specific structure/convention. So I decided to stick with the same organization that already exists in the codebase for now.
@rusackas maybe we could align on a common structure together with the rest of the community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039143611
##########
superset-frontend/src/components/Alert/Alert.stories.tsx:
##########
@@ -30,7 +30,7 @@ const bigText =
'purus convallis placerat in at nunc. Nulla nec viverra augue.';
export default {
- title: 'Alert',
+ title: 'Components/Alert',
Review Comment:
I think it looks better this way too. But if we start doing this it should be standardized as well. cc @geido
##########
superset-frontend/src/components/Chart/DrillBy/useDrillByBreadcrumbs.tsx:
##########
@@ -26,23 +26,23 @@ import {
styled,
Review Comment:
This file is entirely unused if we move the logic back into the DrillByModal. I think having the logic here and using this hook in DrillByModal makes better sense.
##########
superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx:
##########
@@ -308,8 +311,35 @@ export default function DrillByModal({
},
[dispatch, drillByConfigs, formData, getFormDataChangesFromConfigs],
);
-
- const breadcrumbs = useDrillByBreadcrumbs(breadcrumbsData, onBreadcrumbClick);
+ const breadcrumbItems = breadcrumbsData
Review Comment:
I am a bit confused here. We used to have a hook where we extracted this logic into. That hook seems to be unused now? Maybe we should modify the hook to return items and pass those items to breadcrumb here?
##########
superset-frontend/src/components/index.ts:
##########
@@ -24,8 +24,11 @@
*/
// TODO: Remove these imports
// eslint-disable-next-line no-restricted-imports
-export { Breadcrumb as AntdBreadcrumb } from 'antd';
-
+export {
+ Checkbox as AntdCheckbox,
+ Collapse as AntdCollapse,
+ Select as AntdSelect,
+} from 'antd';
Review Comment:
I don't think we should add these imports again here. These component are all migrated to Antd v5.
##########
superset-frontend/src/components/Breadcrumb/Breadcrumb.stories.tsx:
##########
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import type { Meta, StoryObj } from '@storybook/react';
+import { Breadcrumb } from '.';
+
+const meta: Meta<typeof Breadcrumb> = {
+ title: 'Breadcrumb',
+ component: Breadcrumb,
+ tags: ['autodocs'],
+ argTypes: {
+ separator: {
+ control: 'text',
+ description: 'Custom separator between items',
+ defaultValue: '/',
+ },
+ items: {
+ control: 'object',
+ description: 'List of breadcrumb items',
+ defaultValue: [
+ { title: 'Home', href: '/' },
+ { title: 'Library', href: '/library' },
+ { title: 'Data' },
+ ],
+ },
+ },
+};
+
+export default meta;
+type Story = StoryObj<typeof Breadcrumb>;
+
+export const Default: Story = {
Review Comment:
I agree with this as well
##########
superset-frontend/src/components/Breadcrumb/Breadcrumb.test.tsx:
##########
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { Breadcrumb } from '.';
+
+describe('Breadcrumb Component', () => {
+ test('renders breadcrumb items correctly', () => {
+ render(
+ <Breadcrumb>
+ <Breadcrumb.Item>Home</Breadcrumb.Item>
+ <Breadcrumb.Item>Library</Breadcrumb.Item>
+ <Breadcrumb.Item>Data</Breadcrumb.Item>
+ </Breadcrumb>,
+ );
+
+ expect(screen.getByText('Home')).toBeInTheDocument();
Review Comment:
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to AntD v5 [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039183986
##########
superset-frontend/src/components/index.ts:
##########
@@ -24,8 +24,11 @@
*/
// TODO: Remove these imports
// eslint-disable-next-line no-restricted-imports
-export { Breadcrumb as AntdBreadcrumb } from 'antd';
-
+export {
+ Checkbox as AntdCheckbox,
+ Collapse as AntdCollapse,
+ Select as AntdSelect,
+} from 'antd';
Review Comment:
> I don't think we should add these imports again here. These component are all migrated to Antd v5.
I think is a regression after the merge, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org