You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/05/13 17:31:46 UTC
svn commit: r1594248 - in
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async:
AsyncLoggerConfig.java RingBufferLogEvent.java
Author: ggregory
Date: Tue May 13 15:31:46 2014
New Revision: 1594248
URL: http://svn.apache.org/r1594248
Log:
Refactor magic strings into a constant.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEvent.java
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java?rev=1594248&r1=1594247&r2=1594248&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java Tue May 13 15:31:46 2014
@@ -34,6 +34,7 @@ import org.apache.logging.log4j.core.con
import org.apache.logging.log4j.core.config.plugins.PluginFactory;
import org.apache.logging.log4j.core.helpers.Booleans;
import org.apache.logging.log4j.core.jmx.RingBufferAdmin;
+import org.apache.logging.log4j.util.Strings;
/**
* Asynchronous Logger object that is created via configuration and can be
@@ -181,7 +182,7 @@ public class AsyncLoggerConfig extends L
levelName);
level = Level.ERROR;
}
- final String name = loggerName.equals("root") ? "" : loggerName;
+ final String name = loggerName.equals("root") ? Strings.EMPTY : loggerName;
final boolean additive = Booleans.parseBoolean(additivity, true);
return new AsyncLoggerConfig(name, appenderRefs, filter, level,
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEvent.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEvent.java?rev=1594248&r1=1594247&r2=1594248&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEvent.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEvent.java Tue May 13 15:31:46 2014
@@ -29,6 +29,7 @@ import org.apache.logging.log4j.core.loo
import org.apache.logging.log4j.message.Message;
import org.apache.logging.log4j.message.SimpleMessage;
import org.apache.logging.log4j.message.TimestampMessage;
+import org.apache.logging.log4j.util.Strings;
import com.lmax.disruptor.EventFactory;
@@ -154,7 +155,7 @@ public class RingBufferLogEvent implemen
@Override
public Message getMessage() {
if (message == null) {
- message = new SimpleMessage("");
+ message = new SimpleMessage(Strings.EMPTY);
}
return message;
}