You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/20 12:49:42 UTC

[GitHub] [ignite] Vladsz83 opened a new pull request #8484: IGNITE-13705 : Fix middle node failed when failed next node and previous.

Vladsz83 opened a new pull request #8484:
URL: https://github.com/apache/ignite/pull/8484


   Scenario:
   Two nodes fail at the same time. The nodes have relative places in the ring: N-1 and N+2.
   Node N detects failure of node N+1. Node N tries to connect to node N+2. Node N+2 checks backward connection to node N+1.
   
   Problem:
   Node N can fail too.
   
   Cause:
   The timeout on node N to recover connection to node N+2 appears shorter than timeout on node N+2 to check connection to N+1.
   
   Fix:
   Introduced a fundamental timeout value to check/recover connection based on current configuration. Not a constant. Mentioned above timeouts have been made relative. The timeout of backward connection check is now generally shorter than the timeout to recover connection.
   
   Additions:
   - Brought some logs to have diagnostoc ability. It was hard to realize the issue without them.
   - Some renamings and minor optimizations to avoid mess in ping / connection checks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] anton-vinogradov merged pull request #8484: IGNITE-13705 : Another node fails with failure of target node.

Posted by GitBox <gi...@apache.org>.
anton-vinogradov merged pull request #8484:
URL: https://github.com/apache/ignite/pull/8484


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ivandasch commented on a change in pull request #8484: IGNITE-13705 : Another node fails with failure of target node.

Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #8484:
URL: https://github.com/apache/ignite/pull/8484#discussion_r534057218



##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
##########
@@ -236,20 +253,28 @@ public void testFailTwoNodes() throws Exception {
             }, EVT_NODE_SEGMENTED);
         }
 
-        processNetworkThreads(ignite(2), t -> t.suspend());
-        processNetworkThreads(ignite(3), t -> t.suspend());
+        Set<Integer> failedNodes = new HashSet<>();
+
+        failedNodes.add(2);
+
+        if (sequentionally)

Review comment:
       sequentially




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Vladsz83 commented on a change in pull request #8484: IGNITE-13705 : Another node fails with failure of target node.

Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on a change in pull request #8484:
URL: https://github.com/apache/ignite/pull/8484#discussion_r534072460



##########
File path: modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
##########
@@ -236,20 +253,28 @@ public void testFailTwoNodes() throws Exception {
             }, EVT_NODE_SEGMENTED);
         }
 
-        processNetworkThreads(ignite(2), t -> t.suspend());
-        processNetworkThreads(ignite(3), t -> t.suspend());
+        Set<Integer> failedNodes = new HashSet<>();
+
+        failedNodes.add(2);
+
+        if (sequentionally)

Review comment:
       Oh. Ok. I'll fix in another ticked.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org