[GitHub] cloud-fan commented on a change in pull request #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous partition IDs

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous partition IDs
URL: https://github.com/apache/spark/pull/19788#discussion_r242524773
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
 ##########
 @@ -280,10 +282,27 @@ private[spark] abstract class MapOutputTracker(conf: SparkConf) extends Logging
     }
   }
 
+  protected def supportsContinuousBlockBatchFetch(serializerRelocatable: Boolean): Boolean = {
+    if (!conf.getBoolean("spark.shuffle.continuousBlockBatchFetch", true)) {
 
 Review comment:
   it's only used in core module, we can define it in `org.apache.spark.internal.config`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org