You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/01/03 17:47:28 UTC
[GitHub] [incubator-heron] nicknezis opened a new pull request #3753: Updated External JVM Rules plugin
nicknezis opened a new pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753
Updated `bazelbuild/rules_jvm_external` to version 4.2. Changelog can be found here. There were numerous enhancements and bug fixes.
One of the key new features is the addition of the `maven_install.fail_if_repin_required` flag which fails the build if the `maven_install` section was updated, but the pinned artifacts was not also updated.
This PR also replaced some outdated rules that were used in the original migration to the `rules_jvm_external` tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3753: Updated External JVM Rules plugin
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753#issuecomment-1004955471
> Did you mean to delete the `maven_install.json`? We don't have how this plugin works for Heron documented anywhere. Could you add something quick to the instructions on compiling Heron in the website so we don't lose track of this process/tool?
I didn't delete it. Only refreshed it with the newer version of the `rules_jvm_external` build tool. I think the logic for how dependencies are ordered changed, so that caused lots of changes in the json file. But that should be a one time change due to the newer build tool.
General information about the pinning is here: https://github.com/bazelbuild/rules_jvm_external#pinning-artifacts-and-integration-with-bazels-downloader
With this updated version, if anyone ever updates the dependency list and doesn't repin, it will actually fail to compile and give the documentation in the console output for how to refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis merged pull request #3753: Updated External JVM Rules plugin
Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3753: Updated External JVM Rules plugin
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753#issuecomment-1005002359
> > Did you mean to delete the `maven_install.json`? We don't have how this plugin works for Heron documented anywhere. Could you add something quick to the instructions on compiling Heron in the website so we don't lose track of this process/tool?
>
> I didn't delete it. Only refreshed it with the newer version of the `rules_jvm_external` build tool. I think the logic for how dependencies are ordered changed, so that caused lots of changes in the json file. But that should be a one time change due to the newer build tool.
>
> General information about the pinning is here: https://github.com/bazelbuild/rules_jvm_external#pinning-artifacts-and-integration-with-bazels-downloader
>
> With this updated version, if anyone ever updates the dependency list and doesn't repin, it will actually fail to compile and give the documentation in the console output for how to refresh.
Sweet, sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3753: Updated External JVM Rules plugin
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753#issuecomment-1004823779
Did you mean to delete the `maven_install.json`? We don't have how this plugin works for Heron documented anywhere. Could you add something quick to the instructions on compiling Heron in the website so we don't lose track of this process/tool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org