You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Robert Burrell Donkin <ro...@gmail.com> on 2009/09/06 12:23:58 UTC
[smtp] Handler Configuration...?
the services exposed through SMTPHandlerConfigurationData are now injected :-)
all that's left is a simple POJO so i was wondering whether it might
be worthwhile renaming to SMTPConfiguration and replacing the current
interface with an immutable POJO. i agree with your point that the
configuration methods i moved to SMTPSession don't really fit too well
and should be moved probably by injecting the configuration. which
brings us to configuration.
ATM those handlers which need configuration either call the
SMTPSession or implement Configurable. i would prefer to move away
from the Avalon coupling for handlers but i'm not sure the best way
forward.
opinions?
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [smtp] Handler Configuration...?
Posted by Norman Maurer <no...@apache.org>.
I will add it to my todo list..
Enjoy the rest of the day;)
Bye,
Norman
2009/9/6 Robert Burrell Donkin <ro...@gmail.com>:
> On Sun, Sep 6, 2009 at 11:40 AM, Norman Maurer<no...@apache.org> wrote:
>> Comments inline...
>>
>> 2009/9/6 Robert Burrell Donkin <ro...@gmail.com>:
>
> <snip>
>
>>> ATM those handlers which need configuration either call the
>>> SMTPSession or implement Configurable. i would prefer to move away
>>> from the Avalon coupling for handlers but i'm not sure the best way
>>> forward.
>>>
>> +1 Move away from Avalon is the right choice. Why not inject a
>> CommonsConfiguration object and use this as configuration. We could
>> prolly build and Adapter which adapt a Avalon Configuration object to
>> Commons Configuration object. So we could at least elimate any Avalon
>> dependency in the handlers and hooks..
>
> i'm happy with this approach (though i'd be happier for someone else
> to take a look at implementing)
>
> probably have a ConfigurableHandler interface (or something like that)
>
> we probably need a InitialisationHandler interface (or something like
> that) to replace the Avalon lifecycle
>
> BTW i'm out of time today for any more changes to james server
>
> - robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [smtp] Handler Configuration...?
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Sun, Sep 6, 2009 at 11:40 AM, Norman Maurer<no...@apache.org> wrote:
> Comments inline...
>
> 2009/9/6 Robert Burrell Donkin <ro...@gmail.com>:
<snip>
>> ATM those handlers which need configuration either call the
>> SMTPSession or implement Configurable. i would prefer to move away
>> from the Avalon coupling for handlers but i'm not sure the best way
>> forward.
>>
> +1 Move away from Avalon is the right choice. Why not inject a
> CommonsConfiguration object and use this as configuration. We could
> prolly build and Adapter which adapt a Avalon Configuration object to
> Commons Configuration object. So we could at least elimate any Avalon
> dependency in the handlers and hooks..
i'm happy with this approach (though i'd be happier for someone else
to take a look at implementing)
probably have a ConfigurableHandler interface (or something like that)
we probably need a InitialisationHandler interface (or something like
that) to replace the Avalon lifecycle
BTW i'm out of time today for any more changes to james server
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [smtp] Handler Configuration...?
Posted by Norman Maurer <no...@apache.org>.
Comments inline...
2009/9/6 Robert Burrell Donkin <ro...@gmail.com>:
> the services exposed through SMTPHandlerConfigurationData are now injected :-)
>
> all that's left is a simple POJO so i was wondering whether it might
> be worthwhile renaming to SMTPConfiguration and replacing the current
> interface with an immutable POJO. i agree with your point that the
> configuration methods i moved to SMTPSession don't really fit too well
> and should be moved probably by injecting the configuration. which
> brings us to configuration.
+1, There is no need for this interface anymore..
>
> ATM those handlers which need configuration either call the
> SMTPSession or implement Configurable. i would prefer to move away
> from the Avalon coupling for handlers but i'm not sure the best way
> forward.
>
+1 Move away from Avalon is the right choice. Why not inject a
CommonsConfiguration object and use this as configuration. We could
prolly build and Adapter which adapt a Avalon Configuration object to
Commons Configuration object. So we could at least elimate any Avalon
dependency in the handlers and hooks..
> opinions?
>
> - robert
Bye,
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org