You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "denis dudinski (JIRA)" <ji...@codehaus.org> on 2009/04/08 17:48:29 UTC
[jira] Created: (MNG-4126) Properties defined in profiles.xml are
not used during multimodule build when filtering resources in modules.
Properties defined in profiles.xml are not used during multimodule build when filtering resources in modules.
-------------------------------------------------------------------------------------------------------------
Key: MNG-4126
URL: http://jira.codehaus.org/browse/MNG-4126
Project: Maven 2
Issue Type: Bug
Components: Inheritance and Interpolation, Profiles
Affects Versions: 2.1.0
Environment: OS: Windows XP Professional.
Java: 1.4.2_06
Maven: 2.1.0
Reporter: denis dudinski
Attachments: profiles-xml-it.zip
Next multimodule project structure is given:
/
--/parent/
------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
------------profiles.xml - contains custom property "test.property=test-property-value".
--/child/
------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
Maven 2.0.10 behaves in expected way and filters this property in both cases.
See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-4126) [regression] Properties defined in
profiles.xml of parent are not inherited during multimodule build
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-4126.
----------------------------------
Assignee: Benjamin Bentmann
Resolution: Fixed
Fix Version/s: 2.1.1
Fixed in [r763796|http://svn.eu.apache.org/viewvc?view=rev&revision=763796], thanks for the patch!
> [regression] Properties defined in profiles.xml of parent are not inherited during multimodule build
> ----------------------------------------------------------------------------------------------------
>
> Key: MNG-4126
> URL: http://jira.codehaus.org/browse/MNG-4126
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation, Profiles
> Affects Versions: 2.1.0
> Environment: OS: Windows XP Professional.
> Java: 1.4.2_06
> Maven: 2.1.0
> Reporter: denis dudinski
> Assignee: Benjamin Bentmann
> Fix For: 2.1.1
>
> Attachments: DefaultMavenProjectBuilder.patch, profiles-xml-it.zip
>
>
> Next multimodule project structure is given:
> /
> --/parent/
> ------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
> ------------profiles.xml - contains custom property "test.property=test-property-value".
> --/child/
> ------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
> ------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
> So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
> Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
> Maven 2.0.10 behaves in expected way and filters this property in both cases.
> See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4126) [regression] Properties defined in
profiles.xml of parent are not inherited during multimodule build
Posted by "Will Horn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=177224#action_177224 ]
Will Horn commented on MNG-4126:
--------------------------------
Is this fix supposed to be in 2.2.0 RC2? I find my profiles.xml properties are not read by maven.
> [regression] Properties defined in profiles.xml of parent are not inherited during multimodule build
> ----------------------------------------------------------------------------------------------------
>
> Key: MNG-4126
> URL: http://jira.codehaus.org/browse/MNG-4126
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation, Profiles
> Affects Versions: 2.1.0
> Environment: OS: Windows XP Professional.
> Java: 1.4.2_06
> Maven: 2.1.0
> Reporter: denis dudinski
> Assignee: Benjamin Bentmann
> Fix For: 2.2.0
>
> Attachments: DefaultMavenProjectBuilder.patch, profiles-xml-it.zip
>
>
> Next multimodule project structure is given:
> /
> --/parent/
> ------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
> ------------profiles.xml - contains custom property "test.property=test-property-value".
> --/child/
> ------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
> ------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
> So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
> Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
> Maven 2.0.10 behaves in expected way and filters this property in both cases.
> See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4126) Properties defined in profiles.xml are
not used during multimodule build when filtering resources in modules.
Posted by "denis dudinski (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
denis dudinski updated MNG-4126:
--------------------------------
Attachment: DefaultMavenProjectBuilder.patch
Patch that fixes mentioned problem.
> Properties defined in profiles.xml are not used during multimodule build when filtering resources in modules.
> -------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4126
> URL: http://jira.codehaus.org/browse/MNG-4126
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation, Profiles
> Affects Versions: 2.1.0
> Environment: OS: Windows XP Professional.
> Java: 1.4.2_06
> Maven: 2.1.0
> Reporter: denis dudinski
> Attachments: DefaultMavenProjectBuilder.patch, profiles-xml-it.zip
>
>
> Next multimodule project structure is given:
> /
> --/parent/
> ------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
> ------------profiles.xml - contains custom property "test.property=test-property-value".
> --/child/
> ------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
> ------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
> So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
> Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
> Maven 2.0.10 behaves in expected way and filters this property in both cases.
> See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4126) [regression] Properties defined in
profiles.xml of parent are not inherited during multimodule build
Posted by "Will Horn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=177225#action_177225 ]
Will Horn commented on MNG-4126:
--------------------------------
False alarm, the profile in my profiles.xml was not active.
In 2.0.9 my profile was active by default, now I have to explicitly add it to activeProfiles.
> [regression] Properties defined in profiles.xml of parent are not inherited during multimodule build
> ----------------------------------------------------------------------------------------------------
>
> Key: MNG-4126
> URL: http://jira.codehaus.org/browse/MNG-4126
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation, Profiles
> Affects Versions: 2.1.0
> Environment: OS: Windows XP Professional.
> Java: 1.4.2_06
> Maven: 2.1.0
> Reporter: denis dudinski
> Assignee: Benjamin Bentmann
> Fix For: 2.2.0
>
> Attachments: DefaultMavenProjectBuilder.patch, profiles-xml-it.zip
>
>
> Next multimodule project structure is given:
> /
> --/parent/
> ------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
> ------------profiles.xml - contains custom property "test.property=test-property-value".
> --/child/
> ------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
> ------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
> So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
> Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
> Maven 2.0.10 behaves in expected way and filters this property in both cases.
> See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4126) [regression] Properties defined in
profiles.xml of parent are not inherited during multimodule build
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-4126:
-----------------------------------
Summary: [regression] Properties defined in profiles.xml of parent are not inherited during multimodule build (was: Properties defined in profiles.xml are not used during multimodule build when filtering resources in modules.)
This defect applies to POM interpolation as well
> [regression] Properties defined in profiles.xml of parent are not inherited during multimodule build
> ----------------------------------------------------------------------------------------------------
>
> Key: MNG-4126
> URL: http://jira.codehaus.org/browse/MNG-4126
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation, Profiles
> Affects Versions: 2.1.0
> Environment: OS: Windows XP Professional.
> Java: 1.4.2_06
> Maven: 2.1.0
> Reporter: denis dudinski
> Attachments: DefaultMavenProjectBuilder.patch, profiles-xml-it.zip
>
>
> Next multimodule project structure is given:
> /
> --/parent/
> ------------pom.xml - this is aggregator which holds reference to child module in <modules> section.
> ------------profiles.xml - contains custom property "test.property=test-property-value".
> --/child/
> ------------/src/main/resources/child.properties - contains property "some.useful.property=@test.property@". This property should be filtered using value defined - in profiles.xml.
> ------------/pom.xml - contains reference to parent/pom.xml in <parent> pom section.
> So, when I run "mvn clean install" using parent/pom.xml I expect that in child/target/child.properties I will see filtered property "some.useful.property=test-property-value". But property remains unfiltered. src/main/resources in child/pom.xml are marjed as filtered.
> Also, when I run the same command from "child" folder then property is filtered with right value. In single module build all works.
> Maven 2.0.10 behaves in expected way and filters this property in both cases.
> See attached test case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira