You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2006/03/29 13:59:26 UTC
[jira] Commented: (FOR-834) GenericMarkup strips comments
[ http://issues.apache.org/jira/browse/FOR-834?page=comments#action_12372230 ]
Gavin commented on FOR-834:
---------------------------
Possibly related, comments in pelt.fv are causing whitespace in the resultant output.
In this case though I think the comments are intended for dev use and are not to be converted or included in the output as comments or otherwise. The whitespace in place of the comments in the resultant markup are an annoyance more than anything.
e.g. -
<forrest:property name="branding-css-links-input">
<css url="common.css" media="screen" rel="alternate stylesheet"
theme="common"/>
<css url="leather-dev.css" media="screen" rel="alternate stylesheet"
theme="common"/>
<css url="pelt.screen.css" media="screen" theme="Pelt"/>
<!-- You can request request specific css, but beware that you need
to use the *.dispatcher.css extension!!!-->
<!-- FIXME: that is not working ATM in forrest for subdir/bla needs
more testing -->
<!--<css url="#{$getRequest}.dispatcher.css" media="screen"
theme="Pelt"/>-->
<css url="pelt.print.css" media="print"/>
Converts to :-
<link href="themes/common.css" media="screen" rel="alternate stylesheet"
title="common" type="text/css" />
<link href="themes/leather-dev.css" media="screen" rel="alternate
stylesheet" title="common" type="text/css" />
<link href="themes/pelt.screen.css" media="screen" rel="stylesheet"
title="Pelt" type="text/css" />
<link href="themes/pelt.print.css" media="print" rel="stylesheet"
title="pelt.print.css" type="text/css" />
> GenericMarkup strips comments
> -----------------------------
>
> Key: FOR-834
> URL: http://issues.apache.org/jira/browse/FOR-834
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views)
> Versions: 0.8-dev
> Reporter: paul bolger
> Priority: Minor
>
> Comments added to the markup in GenericMarkup are not passed to the output. This has implications for using server side includes within a Forrest site.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
RE: [jira] Commented: (FOR-834) GenericMarkup strips comments
Posted by "Gav...." <br...@brightontown.com.au>.
Relating to Paul's problem of SSI's not being processed due to the fact I
guess that anything starting and ending in <!-- .. --> are told to be
ignored somewhere. I looked in Chaperon etc but guess it must be an xslt
file doing the business here.
Anyway, wherever the comments are being stripped, I wonder if an exclusion
can be made in terms of SSI comment blocks by ignoring the processing of
comments that start and end with <!--# .. -->. I imagine this test can be
checked before the comment one.
Is that feasible, if so where?
Thanks
Gav...
> -----Original Message-----
> From: Gavin (JIRA) [mailto:jira@apache.org]
> Sent: Wednesday, 29 March 2006 7:59 PM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-834) GenericMarkup strips comments
>
> [ http://issues.apache.org/jira/browse/FOR-
> 834?page=comments#action_12372230 ]
>
> Gavin commented on FOR-834:
> ---------------------------
>
> Possibly related, comments in pelt.fv are causing whitespace in the
> resultant output.
> In this case though I think the comments are intended for dev use and are
> not to be converted or included in the output as comments or otherwise.
> The whitespace in place of the comments in the resultant markup are an
> annoyance more than anything.
>
> e.g. -
>
> <forrest:property name="branding-css-links-input">
> <css url="common.css" media="screen" rel="alternate stylesheet"
> theme="common"/>
> <css url="leather-dev.css" media="screen" rel="alternate
> stylesheet"
>
> theme="common"/>
> <css url="pelt.screen.css" media="screen" theme="Pelt"/>
> <!-- You can request request specific css, but beware that you
> need
> to use the *.dispatcher.css extension!!!-->
> <!-- FIXME: that is not working ATM in forrest for subdir/bla
> needs
> more testing -->
> <!--<css url="#{$getRequest}.dispatcher.css" media="screen"
> theme="Pelt"/>-->
> <css url="pelt.print.css" media="print"/>
>
> Converts to :-
>
> <link href="themes/common.css" media="screen" rel="alternate stylesheet"
> title="common" type="text/css" />
> <link href="themes/leather-dev.css" media="screen" rel="alternate
> stylesheet" title="common" type="text/css" />
> <link href="themes/pelt.screen.css" media="screen"
> rel="stylesheet"
> title="Pelt" type="text/css" />
>
>
>
> <link href="themes/pelt.print.css" media="print" rel="stylesheet"
> title="pelt.print.css" type="text/css" />
>
>
> > GenericMarkup strips comments
> > -----------------------------
> >
> > Key: FOR-834
> > URL: http://issues.apache.org/jira/browse/FOR-834
> > Project: Forrest
> > Type: Bug
> > Components: Dispatcher (aka views)
> > Versions: 0.8-dev
> > Reporter: paul bolger
> > Priority: Minor
>
> >
> > Comments added to the markup in GenericMarkup are not passed to the
> output. This has implications for using server side includes within a
> Forrest site.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.385 / Virus Database: 268.3.3/295 - Release Date: 28/03/2006