You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ga...@apache.org on 2018/09/07 23:46:54 UTC
[mesos] branch 1.6.x updated (bf5e39f -> ca82dbb)
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a change to branch 1.6.x
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from bf5e39f Added MESOS-8568 to the 1.6.2 CHANGELOG.
new ff7fbcc Revert "Set 'Connection: close' in the master's streaming API responses."
new ca82dbb Revert "Added MESOS-9189 to the 1.6.2 CHANGELOG."
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGELOG | 3 ---
src/master/http.cpp | 29 -----------------------------
2 files changed, 32 deletions(-)
[mesos] 01/02: Revert "Set 'Connection: close' in the master's
streaming API responses."
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a commit to branch 1.6.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit ff7fbcc30c708a8ba0b8aace1f5649686c02878c
Author: Gastón Kleiman <ga...@apache.org>
AuthorDate: Fri Sep 7 16:38:26 2018 -0700
Revert "Set 'Connection: close' in the master's streaming API responses."
This reverts commit 993a0004a4fdbd6b5b2174ffe12bc985193a3f1d.
---
src/master/http.cpp | 29 -----------------------------
1 file changed, 29 deletions(-)
diff --git a/src/master/http.cpp b/src/master/http.cpp
index bda0439..0492b97 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -831,20 +831,6 @@ Future<Response> Master::Http::subscribe(
Pipe pipe;
OK ok;
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // subscribers do not get removed when the end client
- // disconnects!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(contentType);
ok.type = Response::PIPE;
ok.reader = pipe.reader();
@@ -1026,21 +1012,6 @@ Future<Response> Master::Http::scheduler(
Pipe pipe;
OK ok;
-
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // scheduler would not get removed when it disconnects from
- // the intermediary!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(acceptType);
ok.type = Response::PIPE;
[mesos] 02/02: Revert "Added MESOS-9189 to the 1.6.2 CHANGELOG."
Posted by ga...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a commit to branch 1.6.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit ca82dbbc94b759c8cde42f718fbcbe532edf6f12
Author: Gastón Kleiman <ga...@apache.org>
AuthorDate: Fri Sep 7 16:38:40 2018 -0700
Revert "Added MESOS-9189 to the 1.6.2 CHANGELOG."
This reverts commit 918504ebe594df6104a9194479b0b24a9cc48197.
---
CHANGELOG | 3 ---
1 file changed, 3 deletions(-)
diff --git a/CHANGELOG b/CHANGELOG
index dacc2d7..4f3b5cc 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -18,9 +18,6 @@ Release Notes - Mesos - Version 1.6.2 (WIP)
* [MESOS-9170] - Zookeeper doesn't compile with newer gcc due to format error.
* [MESOS-9196] - Removing rootfs mounts may fail with EBUSY.
-** Improvement
- * [MESOS-9189] - Include 'Connection: close' header in master streaming API responses.
-
Release Notes - Mesos - Version 1.6.1
-------------------------------------------