You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@slider.apache.org by jm...@apache.org on 2014/10/31 02:31:58 UTC
git commit: SLIDER-574 print log message when no service keytabs are
localized
Repository: incubator-slider
Updated Branches:
refs/heads/develop 1a071e31d -> e23e680fe
SLIDER-574 print log message when no service keytabs are localized
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/e23e680f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/e23e680f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/e23e680f
Branch: refs/heads/develop
Commit: e23e680fe8e329410126ff4a83ad004ce91b528a
Parents: 1a071e3
Author: Jon Maron <jm...@hortonworks.com>
Authored: Thu Oct 30 21:31:41 2014 -0400
Committer: Jon Maron <jm...@hortonworks.com>
Committed: Thu Oct 30 21:31:41 2014 -0400
----------------------------------------------------------------------
.../apache/slider/providers/agent/AgentProviderService.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/e23e680f/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
----------------------------------------------------------------------
diff --git a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
index 934e5f0..4720ced 100644
--- a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
+++ b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
@@ -521,9 +521,11 @@ public class AgentProviderService extends AbstractProviderService implements
getClusterName());
FileStatus[] keytabs = fileSystem.getFileSystem().listStatus(keytabDirPath);
LocalResource keytabRes;
+ boolean serviceKeytabsDeployed = false;
for (FileStatus keytab : keytabs) {
if (!amKeytabName.equals(keytab.getPath().getName())
&& keytab.getPath().getName().endsWith(".keytab")) {
+ serviceKeytabsDeployed = true;
log.info("Localizing keytab {}", keytab.getPath().getName());
keytabRes = fileSystem.createAmResource(keytab.getPath(),
LocalResourceType.FILE);
@@ -532,6 +534,13 @@ public class AgentProviderService extends AbstractProviderService implements
keytabRes);
}
}
+ if (!serviceKeytabsDeployed) {
+ log.warn("No service keytabs for the application have been localized. "
+ + "If the application requires keytabs for secure operation, "
+ + "please ensure that the required keytabs have been uploaded "
+ + "to the folder designated by the property {}: {}",
+ SliderXmlConfKeys.KEY_HDFS_KEYTAB_DIR, keytabDirPath);
+ }
}
}
Re: git commit: SLIDER-574 print log message when no service keytabs are localized
Posted by Jon Maron <jm...@hortonworks.com>.
Mistakenly associated with SLIDER-574. Should be associated with SLIDER-577.
On Oct 30, 2014, at 9:31 PM, jmaron@apache.org wrote:
> Repository: incubator-slider
> Updated Branches:
> refs/heads/develop 1a071e31d -> e23e680fe
>
>
> SLIDER-574 print log message when no service keytabs are localized
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/e23e680f
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/e23e680f
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/e23e680f
>
> Branch: refs/heads/develop
> Commit: e23e680fe8e329410126ff4a83ad004ce91b528a
> Parents: 1a071e3
> Author: Jon Maron <jm...@hortonworks.com>
> Authored: Thu Oct 30 21:31:41 2014 -0400
> Committer: Jon Maron <jm...@hortonworks.com>
> Committed: Thu Oct 30 21:31:41 2014 -0400
>
> ----------------------------------------------------------------------
> .../apache/slider/providers/agent/AgentProviderService.java | 9 +++++++++
> 1 file changed, 9 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/e23e680f/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> ----------------------------------------------------------------------
> diff --git a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> index 934e5f0..4720ced 100644
> --- a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> +++ b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> @@ -521,9 +521,11 @@ public class AgentProviderService extends AbstractProviderService implements
> getClusterName());
> FileStatus[] keytabs = fileSystem.getFileSystem().listStatus(keytabDirPath);
> LocalResource keytabRes;
> + boolean serviceKeytabsDeployed = false;
> for (FileStatus keytab : keytabs) {
> if (!amKeytabName.equals(keytab.getPath().getName())
> && keytab.getPath().getName().endsWith(".keytab")) {
> + serviceKeytabsDeployed = true;
> log.info("Localizing keytab {}", keytab.getPath().getName());
> keytabRes = fileSystem.createAmResource(keytab.getPath(),
> LocalResourceType.FILE);
> @@ -532,6 +534,13 @@ public class AgentProviderService extends AbstractProviderService implements
> keytabRes);
> }
> }
> + if (!serviceKeytabsDeployed) {
> + log.warn("No service keytabs for the application have been localized. "
> + + "If the application requires keytabs for secure operation, "
> + + "please ensure that the required keytabs have been uploaded "
> + + "to the folder designated by the property {}: {}",
> + SliderXmlConfKeys.KEY_HDFS_KEYTAB_DIR, keytabDirPath);
> + }
> }
> }
>
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: git commit: SLIDER-574 print log message when no service keytabs are localized
Posted by Jon Maron <jm...@hortonworks.com>.
Mistakenly associated with SLIDER-574. Should be associated with SLIDER-577.
On Oct 30, 2014, at 9:31 PM, jmaron@apache.org wrote:
> Repository: incubator-slider
> Updated Branches:
> refs/heads/develop 1a071e31d -> e23e680fe
>
>
> SLIDER-574 print log message when no service keytabs are localized
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/e23e680f
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/e23e680f
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/e23e680f
>
> Branch: refs/heads/develop
> Commit: e23e680fe8e329410126ff4a83ad004ce91b528a
> Parents: 1a071e3
> Author: Jon Maron <jm...@hortonworks.com>
> Authored: Thu Oct 30 21:31:41 2014 -0400
> Committer: Jon Maron <jm...@hortonworks.com>
> Committed: Thu Oct 30 21:31:41 2014 -0400
>
> ----------------------------------------------------------------------
> .../apache/slider/providers/agent/AgentProviderService.java | 9 +++++++++
> 1 file changed, 9 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/e23e680f/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> ----------------------------------------------------------------------
> diff --git a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> index 934e5f0..4720ced 100644
> --- a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> +++ b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
> @@ -521,9 +521,11 @@ public class AgentProviderService extends AbstractProviderService implements
> getClusterName());
> FileStatus[] keytabs = fileSystem.getFileSystem().listStatus(keytabDirPath);
> LocalResource keytabRes;
> + boolean serviceKeytabsDeployed = false;
> for (FileStatus keytab : keytabs) {
> if (!amKeytabName.equals(keytab.getPath().getName())
> && keytab.getPath().getName().endsWith(".keytab")) {
> + serviceKeytabsDeployed = true;
> log.info("Localizing keytab {}", keytab.getPath().getName());
> keytabRes = fileSystem.createAmResource(keytab.getPath(),
> LocalResourceType.FILE);
> @@ -532,6 +534,13 @@ public class AgentProviderService extends AbstractProviderService implements
> keytabRes);
> }
> }
> + if (!serviceKeytabsDeployed) {
> + log.warn("No service keytabs for the application have been localized. "
> + + "If the application requires keytabs for secure operation, "
> + + "please ensure that the required keytabs have been uploaded "
> + + "to the folder designated by the property {}: {}",
> + SliderXmlConfKeys.KEY_HDFS_KEYTAB_DIR, keytabDirPath);
> + }
> }
> }
>
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.