[GitHub] [spark] pan3793 edited a comment on pull request #33989: [SPARK-36676][SQL][BUILD] Create shaded Hive module and upgrade Guava version to 30.1.1-jre

[GitBox <gi...@apache.org>]

pan3793 edited a comment on pull request #33989:
URL: https://github.com/apache/spark/pull/33989#issuecomment-919637709


   If I understand correctly, the `hive-shaded` module creates a fat jar that contains all hive classes and the classes from transitive dependencies of hive, but only a few classes are relocated. (Correct me if I'm wrong)
   
   That means those classes which are not relocated will cause class conflict if the user also provides the original jars, e.g. HikariCP.
   
   For this case, maybe we can learn something from https://github.com/trinodb/trino-hive-apache


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org