[GitHub] [incubator-doris] imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load
URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319030547
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/planner/ScanNode.java
 ##########
 @@ -37,6 +50,9 @@
     protected final TupleDescriptor desc;
     protected Map<String, PartitionColumnFilter> columnFilters;
     protected String sortColumn = null;
+    protected Map<String, SlotDescriptor> slotDescByName = Maps.newHashMap();
 
 Review comment:
   If you want to unify BrokerScanNode and StreamScanNode, I think you'd better to make another class which is subclass of ScanNode. Because not all ScanNode has these properties, they only are used in loading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org