You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/18 16:30:10 UTC

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20034: Change *_mkldnn* test and build scenarios names to *_onednn*

bartekkuncer commented on a change in pull request #20034:
URL: https://github.com/apache/incubator-mxnet/pull/20034#discussion_r595835147



##########
File path: ci/dev_menu.py
##########
@@ -148,7 +148,7 @@ def provision_virtualenv(venv_path=DEFAULT_PYENV):
     ]),
     ('[Docker] Python3 CPU Intel MKLDNN unittests',
     [
-        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_mkldnn",
+        "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh build_ubuntu_cpu_onednn",
         "ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh unittest_ubuntu_python3_cpu",
     ]),
     ('[Docker] Python3 ARMv7 unittests (QEMU)',

Review comment:
       @szha @leezu I saw that some of the functions called here are not present in ci/docker/runtime_functions.sh file. Is there a separate file for CI stored outside of this repository or maybe these names should be updated?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org