[GitHub] [spark] cdkrot commented on a diff in pull request #41807: [SPARK-44263][CONNECT] Channel Builder support

["cdkrot (via GitHub)" <gi...@apache.org>]

cdkrot commented on code in PR #41807:
URL: https://github.com/apache/spark/pull/41807#discussion_r1251727325


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -628,8 +625,13 @@ object SparkSession extends Logging {
   /**
    * Create a new [[SparkSession]] based on the connect client [[Configuration]].
    */
-  private[sql] def create(configuration: Configuration): SparkSession = {
-    new SparkSession(new SparkConnectClient(configuration), cleaner, planIdGenerator)
+  private[sql] def create(
+      configuration: Configuration,
+      channelBuilder: Option[ChannelBuilder] = None): SparkSession = {

Review Comment:
   We can, I am open to discuss this.
   
   The reason I didn't do it this way, is that it would make a bidirectional dependency between Configuration and ChannelBuilder. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org