You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/04 15:47:56 UTC

[GitHub] [hudi] veenaypatil opened a new pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

veenaypatil opened a new pull request #3404:
URL: https://github.com/apache/hudi/pull/3404


   ## What is the purpose of the pull request
   
   Details added here - https://issues.apache.org/jira/browse/HUDI-2257
   
   ## Brief change log
   
   Updated blog to add Note and set KeyGen class
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [X] Has a corresponding JIRA in PR title & commit
    
    - [X] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vingov commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893164594


   looking into it, my local env is not matching travis env, replicating the same docker image and testing it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vingov commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893051174






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vingov commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893683457


   @veenaypatil - I fixed the build issues, can you please rebase your branch with the latest asf-site branch and push again to fix this build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3404:
URL: https://github.com/apache/hudi/pull/3404


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-892991015


   @vingov : hey can you help out here. Author did a complete redo of the previous patch. Again, build is failing. I don't understand the build errors. Can you look at the build errors and suggest ways to fix it. or whats the actual issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vingov commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893051174


   @nsivabalan - I guess it's a dependency version mismatch issue, let me add the package-lock.json so that the versions will be locked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vingov commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893069533


   @nsivabalan @veenaypatil - Fixed the build issue in this [PR](https://github.com/apache/hudi/pull/3410), once the CI is green we can merge, after which we can rebase this branch to fix the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-892991015






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3404: [HUDI-2257] Adding note to set Keygen class while deleting data

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3404:
URL: https://github.com/apache/hudi/pull/3404#issuecomment-893157959


   thanks. looks like CI failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org