You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/15 21:51:06 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #7893: Add barriers in kvstore init
eric-haibin-lin commented on a change in pull request #7893: Add barriers in kvstore init
URL: https://github.com/apache/incubator-mxnet/pull/7893#discussion_r139257114
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -147,8 +147,11 @@ class KVStoreDist : public KVStoreLocal {
for (const auto& v : values) {
v.WaitToWrite();
}
+ // wait for rank 0
+ Barrier();
} else {
- // do nothing
+ // wait for rank 0
+ Barrier();
}
if (!ps::Postoffice::Get()->is_recovery()) {
Review comment:
The `Barrier()` call at line 157 should be sufficient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services