[jira] Commented: (JS2-1024) mssql create-schema.sql is incorrect

["Ate Douma (JIRA)" <je...@portals.apache.org>]

    [ https://issues.apache.org/jira/browse/JS2-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716244#action_12716244 ] 

Ate Douma commented on JS2-1024:
--------------------------------

Hi Frank,

Thanks for the patches, but I'm afraid they are not yet good enough to incorporate in the jetspeed src.
I see a lot of changes on column data types (e.g. INT -> INTEGER) and adjustments for the changed table definitions, which seems fine to me.

But, what has gone missing (including possible required adjustments) is all the required mssql trigger code.
For mssql, as it doesn't properly support (standard) cascade deletes for hierarchical references, there were are several tables which has additional triggers to deal with that functionality (e.g. FOLDER, FOLDER_MENU, FRAGMENT, PAGE_MENU).
In your environment you might not be yet using database stored psml, but to be able to do so, these additional triggers are required to handle hierarchical references on delete.
And the same and even more so applies to the drop-schema.sql!
You might also might want to review the issues JS2-812 and JS2-838 which specifically dealt with these problems and were the basis for the current (but now outdated) hand crafted mssql schema sql.  

> mssql create-schema.sql is incorrect
> ------------------------------------
>
>                 Key: JS2-1024
>                 URL: https://issues.apache.org/jira/browse/JS2-1024
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Persistence and DAO
>    Affects Versions: 2.2.0
>            Reporter: Frank Otto
>            Assignee: Ate Douma
>             Fix For: 2.2.1
>
>         Attachments: create-schema.sql, drop-schema.sql
>
>
> The mssql create-schema.sql contains old tables less tables then in derbydb create-schema.sql. 
> for example: table SECURITY_DOMAIN is missing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org